chrome/browser/extensions/api/gcm/gcm_api.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/gcm/gcm_api.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/gcd_private/privet_v3_session_unittest.cc ('k') | chrome/browser/extensions/api/history/history_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/gcm/gcm_api.cc

diff --git a/chrome/browser/extensions/api/gcm/gcm_api.cc b/chrome/browser/extensions/api/gcm/gcm_api.cc

index b658e7780b8257fcacb46546913fc9b365b47730..abb68abb8de3c8b97dd5c7314590ba0920fcb398 100644

--- a/chrome/browser/extensions/api/gcm/gcm_api.cc

+++ b/chrome/browser/extensions/api/gcm/gcm_api.cc

@@ -5,9 +5,9 @@

#include "chrome/browser/extensions/api/gcm/gcm_api.h"

#include <stddef.h>

#include <algorithm>

#include <map>

+#include <utility>

#include <vector>

#include "base/macros.h"

@@ -219,15 +219,17 @@ void GcmJsEventRouter::OnMessage(const std::string& app_id,

scoped_ptr<Event> event(

new Event(events::GCM_ON_MESSAGE, api::gcm::OnMessage::kEventName,

- api::gcm::OnMessage::Create(message_arg).Pass(), profile_));

- EventRouter::Get(profile_)->DispatchEventToExtension(app_id, event.Pass());

+ api::gcm::OnMessage::Create(message_arg), profile_));

+ EventRouter::Get(profile_)

+ ->DispatchEventToExtension(app_id, std::move(event));

}

void GcmJsEventRouter::OnMessagesDeleted(const std::string& app_id) {

scoped_ptr<Event> event(new Event(

events::GCM_ON_MESSAGES_DELETED, api::gcm::OnMessagesDeleted::kEventName,

- api::gcm::OnMessagesDeleted::Create().Pass(), profile_));

- EventRouter::Get(profile_)->DispatchEventToExtension(app_id, event.Pass());

+ api::gcm::OnMessagesDeleted::Create(), profile_));

+ EventRouter::Get(profile_)

+ ->DispatchEventToExtension(app_id, std::move(event));

}

void GcmJsEventRouter::OnSendError(

@@ -240,8 +242,9 @@ void GcmJsEventRouter::OnSendError(

scoped_ptr<Event> event(

new Event(events::GCM_ON_SEND_ERROR, api::gcm::OnSendError::kEventName,

- api::gcm::OnSendError::Create(error).Pass(), profile_));

- EventRouter::Get(profile_)->DispatchEventToExtension(app_id, event.Pass());

+ api::gcm::OnSendError::Create(error), profile_));

+ EventRouter::Get(profile_)

+ ->DispatchEventToExtension(app_id, std::move(event));

}

} // namespace extensions