Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2038)

Unified Diff: chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc
diff --git a/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc b/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc
index 8a62c9c3aa569652be45353d6739325b90ab54ed..0290f987b5e09de56a9167fb83f1b0316f3b76a1 100644
--- a/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc
+++ b/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc
@@ -4,6 +4,8 @@
#include "chrome/browser/extensions/api/experience_sampling_private/experience_sampling.h"
+#include <utility>
+
#include "base/values.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/profiles/profile.h"
@@ -83,12 +85,13 @@ void ExperienceSamplingEvent::CreateUserDecisionEvent(
scoped_ptr<base::ListValue> args(new base::ListValue());
args->Append(ui_element_.ToValue().release());
args->Append(decision.ToValue().release());
- scoped_ptr<Event> event(new Event(
- events::EXPERIENCE_SAMPLING_PRIVATE_ON_DECISION,
- api::experience_sampling_private::OnDecision::kEventName, args.Pass()));
+ scoped_ptr<Event> event(
+ new Event(events::EXPERIENCE_SAMPLING_PRIVATE_ON_DECISION,
+ api::experience_sampling_private::OnDecision::kEventName,
+ std::move(args)));
EventRouter* router = EventRouter::Get(browser_context_);
if (router)
- router->BroadcastEvent(event.Pass());
+ router->BroadcastEvent(std::move(event));
}
void ExperienceSamplingEvent::CreateOnDisplayedEvent() {
@@ -98,12 +101,13 @@ void ExperienceSamplingEvent::CreateOnDisplayedEvent() {
return;
scoped_ptr<base::ListValue> args(new base::ListValue());
args->Append(ui_element_.ToValue().release());
- scoped_ptr<Event> event(new Event(
- events::EXPERIENCE_SAMPLING_PRIVATE_ON_DISPLAYED,
- api::experience_sampling_private::OnDisplayed::kEventName, args.Pass()));
+ scoped_ptr<Event> event(
+ new Event(events::EXPERIENCE_SAMPLING_PRIVATE_ON_DISPLAYED,
+ api::experience_sampling_private::OnDisplayed::kEventName,
+ std::move(args)));
EventRouter* router = EventRouter::Get(browser_context_);
if (router)
- router->BroadcastEvent(event.Pass());
+ router->BroadcastEvent(std::move(event));
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698