chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc ('k') | chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

index 5b9953a45ca7a5d2390e65696aab7a5d764065fc..c53bb748c88bac9f41480514df598c4bdc8452f6 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

+++ b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

@@ -255,14 +255,14 @@ TEST_F(RulesRegistryWithCacheTest, DeclarativeRulesStored) {

scoped_ptr<base::ListValue> value(new base::ListValue);

value->AppendBoolean(true);

- cache_delegate->WriteToStorage(extension1_->id(), value.Pass());

+ cache_delegate->WriteToStorage(extension1_->id(), std::move(value));

EXPECT_TRUE(cache_delegate->GetDeclarativeRulesStored(extension1_->id()));

base::RunLoop().RunUntilIdle();

EXPECT_EQ(write_count + 1, store->write_count());

write_count = store->write_count();

value.reset(new base::ListValue);

- cache_delegate->WriteToStorage(extension1_->id(), value.Pass());

+ cache_delegate->WriteToStorage(extension1_->id(), std::move(value));

EXPECT_FALSE(cache_delegate->GetDeclarativeRulesStored(extension1_->id()));

base::RunLoop().RunUntilIdle();

// No rules currently, but previously there were, so we expect a write.

@@ -270,7 +270,7 @@ TEST_F(RulesRegistryWithCacheTest, DeclarativeRulesStored) {

write_count = store->write_count();

value.reset(new base::ListValue);

- cache_delegate->WriteToStorage(extension1_->id(), value.Pass());

+ cache_delegate->WriteToStorage(extension1_->id(), std::move(value));

EXPECT_FALSE(cache_delegate->GetDeclarativeRulesStored(extension1_->id()));

base::RunLoop().RunUntilIdle();

EXPECT_EQ(write_count, store->write_count());