chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/automation_internal/automation_event_router.cc ('k') | chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc

diff --git a/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc b/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc

index 0e00931b0aff6edb8a60950202f39540d0d2b1b9..20d3bffdb004469402909d46d21ea0b95b09aea7 100644

--- a/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc

+++ b/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc

@@ -5,8 +5,8 @@

#include "chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.h"

#include <stdint.h>

#include <algorithm>

+#include <utility>

#include "base/bind.h"

#include "base/command_line.h"

@@ -935,21 +935,20 @@ bool BluetoothLowEnergyRegisterAdvertisementFunction::DoWork() {

ADVERTISEMENT_TYPE_PERIPHERAL));

advertisement_data->set_service_uuids(

- params->advertisement.service_uuids.Pass());

+ std::move(params->advertisement.service_uuids));

advertisement_data->set_solicit_uuids(

- params->advertisement.solicit_uuids.Pass());

+ std::move(params->advertisement.solicit_uuids));

if (params->advertisement.manufacturer_data) {

advertisement_data->set_manufacturer_data(

- CreateManufacturerData(params->advertisement.manufacturer_data.get())

- .Pass());

+ CreateManufacturerData(params->advertisement.manufacturer_data.get()));

}

if (params->advertisement.service_data) {

advertisement_data->set_service_data(

- CreateServiceData(params->advertisement.service_data.get()).Pass());

+ CreateServiceData(params->advertisement.service_data.get()));

}

event_router->adapter()->RegisterAdvertisement(

- advertisement_data.Pass(),

+ std::move(advertisement_data),

base::Bind(

&BluetoothLowEnergyRegisterAdvertisementFunction::SuccessCallback,

this),