chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/autofill_private/autofill_private_api.cc ('k') | chrome/browser/extensions/api/autofill_private/autofill_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc

diff --git a/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc b/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc

index 6765eaee5899c9d9dc7e499a95cc946bf619d6a1..e92504c9db5e95c8b28b5d4f6e68a269d34b27fb 100644

--- a/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc

+++ b/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/extensions/api/autofill_private/autofill_private_event_router.h"

+#include <utility>

#include <vector>

#include "base/bind.h"

@@ -83,20 +84,22 @@ void AutofillPrivateEventRouter::OnPersonalDataChanged() {

scoped_ptr<base::ListValue> args(

api::autofill_private::OnAddressListChanged::Create(*addressList)

.release());

- scoped_ptr<Event> extension_event(new Event(

- events::AUTOFILL_PRIVATE_ON_ADDRESS_LIST_CHANGED,

- api::autofill_private::OnAddressListChanged::kEventName, args.Pass()));

- event_router_->BroadcastEvent(extension_event.Pass());

+ scoped_ptr<Event> extension_event(

+ new Event(events::AUTOFILL_PRIVATE_ON_ADDRESS_LIST_CHANGED,

+ api::autofill_private::OnAddressListChanged::kEventName,

+ std::move(args)));

+ event_router_->BroadcastEvent(std::move(extension_event));

scoped_ptr<CreditCardEntryList> creditCardList =

extensions::autofill_util::GenerateCreditCardList(*personal_data_);

args.reset(

api::autofill_private::OnCreditCardListChanged::Create(*creditCardList)

.release());

- extension_event.reset(new Event(

- events::AUTOFILL_PRIVATE_ON_CREDIT_CARD_LIST_CHANGED,

- api::autofill_private::OnCreditCardListChanged::kEventName, args.Pass()));

- event_router_->BroadcastEvent(extension_event.Pass());

+ extension_event.reset(

+ new Event(events::AUTOFILL_PRIVATE_ON_CREDIT_CARD_LIST_CHANGED,

+ api::autofill_private::OnCreditCardListChanged::kEventName,

+ std::move(args)));

+ event_router_->BroadcastEvent(std::move(extension_event));

}

void AutofillPrivateEventRouter::StartOrStopListeningForChanges() {