Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4037)

Unified Diff: chrome/browser/extensions/api/audio_modem/audio_modem_api_unittest.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/audio_modem/audio_modem_api_unittest.cc
diff --git a/chrome/browser/extensions/api/audio_modem/audio_modem_api_unittest.cc b/chrome/browser/extensions/api/audio_modem/audio_modem_api_unittest.cc
index d1d0c5e1fad246f8a46b9a545ff7ab8cdb7b7148..b180ca70484b75484a3301743a5c93cda23a0ee1 100644
--- a/chrome/browser/extensions/api/audio_modem/audio_modem_api_unittest.cc
+++ b/chrome/browser/extensions/api/audio_modem/audio_modem_api_unittest.cc
@@ -72,14 +72,14 @@ BinaryValue* CreateToken(const std::string& token) {
scoped_ptr<ListValue> CreateList(Value* single_elt) {
scoped_ptr<ListValue> list(new ListValue);
list->Append(single_elt);
- return list.Pass();
+ return list;
}
scoped_ptr<ListValue> CreateList(Value* elt1, Value* elt2) {
scoped_ptr<ListValue> list(new ListValue);
list->Append(elt1);
list->Append(elt2);
- return list.Pass();
+ return list;
}
DictionaryValue* CreateReceivedToken(const std::string& token,
@@ -116,7 +116,7 @@ class StubEventRouter : public EventRouter {
void DispatchEventToExtension(const std::string& extension_id,
scoped_ptr<Event> event) override {
- event_callback_.Run(extension_id, event.Pass());
+ event_callback_.Run(extension_id, std::move(event));
}
void SetEventCallBack(EventCallback event_callback) {
@@ -152,8 +152,8 @@ class AudioModemApiUnittest : public ExtensionApiUnittest {
function->set_extension(extension);
function->set_browser_context(profile());
function->set_has_callback(true);
- ext_test_utils::RunFunction(
- function.get(), args.Pass(), browser(), ext_test_utils::NONE);
+ ext_test_utils::RunFunction(function.get(), std::move(args), browser(),
+ ext_test_utils::NONE);
std::string result_status;
CHECK(function->GetResultList()->GetString(0, &result_status));
@@ -162,7 +162,7 @@ class AudioModemApiUnittest : public ExtensionApiUnittest {
template<typename Function>
const std::string RunFunction(scoped_ptr<ListValue> args) {
- return RunFunction<Function>(args.Pass(), GetExtension(std::string()));
+ return RunFunction<Function>(std::move(args), GetExtension(std::string()));
}
StubModem* GetModem() const {

Powered by Google App Engine
This is Rietveld 408576698