chrome/browser/extensions/activity_log/activity_log.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/activity_log.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/activity_actions.cc ('k') | chrome/browser/extensions/activity_log/counting_policy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/activity_log.cc

diff --git a/chrome/browser/extensions/activity_log/activity_log.cc b/chrome/browser/extensions/activity_log/activity_log.cc

index 3fe65eae91871142e76cdefdccf282e998d02aa8..0f9d04a9c6742db375c0c23b611ddfba71341d81 100644

--- a/chrome/browser/extensions/activity_log/activity_log.cc

+++ b/chrome/browser/extensions/activity_log/activity_log.cc

@@ -5,8 +5,8 @@

#include "chrome/browser/extensions/activity_log/activity_log.h"

#include <stddef.h>

#include <set>

+#include <utility>

#include <vector>

#include "base/command_line.h"

@@ -586,7 +586,7 @@ void ActivityLog::OnApiEventDispatched(const std::string& extension_id,

base::Time::Now(),

Action::ACTION_API_EVENT,

event_name);

- action->set_args(event_args.Pass());

+ action->set_args(std::move(event_args));

LogAction(action);

}

@@ -598,7 +598,7 @@ void ActivityLog::OnApiFunctionCalled(const std::string& extension_id,

base::Time::Now(),

Action::ACTION_API_CALL,

api_name);

- action->set_args(args.Pass());

+ action->set_args(std::move(args));

LogAction(action);

}