Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1549203002: Switch to standard integer types in tools/. (Closed)

Created:
4 years, 12 months ago by Avi (use Gerrit)
Modified:
4 years, 12 months ago
Reviewers:
Nico
CC:
chromium-reviews, tfarina, telemetry-reviews_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to standard integer types in tools/. BUG=138542 TBR=thakis@chromium.org Committed: https://crrev.com/cab0f83c7f6c4401bc59c8b797461b6a2f7b08e1 Cr-Commit-Position: refs/heads/master@{#366895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+387 lines, -164 lines) Patch
M tools/android/common/adb_connection.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/android/common/net.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/android/file_poller/file_poller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/android/forwarder/forwarder.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/android/forwarder2/command.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/android/forwarder2/common.h View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/android/forwarder2/daemon.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/daemon.cc View 2 chunks +1 line, -1 line 0 comments Download
M tools/android/forwarder2/device_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/device_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/android/forwarder2/device_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/forwarder.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/forwarders_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/android/forwarder2/host_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/host_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/android/forwarder2/host_forwarder_main.cc View 4 chunks +4 lines, -2 lines 0 comments Download
M tools/android/forwarder2/pipe_notifier.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/self_deleter_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/socket.h View 1 chunk +2 lines, -1 line 0 comments Download
M tools/android/forwarder2/socket.cc View 2 chunks +2 lines, -1 line 0 comments Download
M tools/android/heap_profiler/heap_dump.c View 1 chunk +4 lines, -3 lines 0 comments Download
M tools/android/heap_profiler/heap_profiler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/android/heap_profiler/heap_profiler_hooks_android.c View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/android/heap_profiler/heap_profiler_integrationtest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/android/heap_profiler/heap_profiler_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/android/md5sum/md5sum.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/android/memdump/memdump.cc View 10 chunks +21 lines, -21 lines 0 comments Download
M tools/battor_agent/battor_agent_bin.cc View 2 chunks +3 lines, -1 line 0 comments Download
M tools/battor_agent/battor_connection.h View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/battor_agent/battor_connection_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/battor_agent/battor_protocol_types.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/cygprofile/cygprofile.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M tools/cygprofile/cygprofile_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/gn/builder.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/c_include_iterator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/c_include_iterator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/c_include_iterator_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/command_args.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/gn/command_check.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/command_desc.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gn/command_format.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gn/command_path.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/command_refs.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/config_values_extractors.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/deps_iterator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/err.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/escape.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gn/exec_process.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/filesystem_utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/function_get_path_info.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/function_get_path_info_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/function_rebase_path.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/function_write_file.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/function_write_file_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M tools/gn/functions.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/generate_test_gn_data.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/gn_main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/import_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/inherited_libraries.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/input_conversion.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/label.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/label.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/label_pattern.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gn/label_pattern_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gn/label_ptr.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/label_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/gn/lib_file.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/ninja_action_target_writer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/ninja_action_target_writer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/ninja_binary_target_writer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gn/ninja_build_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/ninja_build_writer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/ninja_toolchain_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/operators.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/operators_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M tools/gn/ordered_set.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/output_file.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/parse_tree.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/parse_tree.cc View 4 chunks +11 lines, -8 lines 0 comments Download
M tools/gn/parse_tree_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M tools/gn/parser.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/path_output_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/pattern.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/pattern_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gn/runtime_deps_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/settings.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/source_dir.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/source_dir.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/source_dir_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/source_file.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/standard_out.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/string_utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/string_utils_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M tools/gn/substitution_list.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/substitution_pattern.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/substitution_type.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/substitution_writer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/target.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/target_generator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/tokenizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/tokenizer_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/toolchain.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/trace.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/gn/unique_vector.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/unique_vector_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/value.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/value_extractors.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/value_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M tools/imagediff/image_diff.cc View 7 chunks +15 lines, -12 lines 0 comments Download
M tools/imagediff/image_diff_png.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/ipc_fuzzer/fuzzer/fuzzer.h View 4 chunks +12 lines, -10 lines 0 comments Download
M tools/ipc_fuzzer/fuzzer/fuzzer.cc View 16 chunks +22 lines, -20 lines 0 comments Download
M tools/ipc_fuzzer/fuzzer/fuzzer_main.cc View 2 chunks +4 lines, -1 line 0 comments Download
M tools/ipc_fuzzer/fuzzer/generator.h View 2 chunks +7 lines, -4 lines 0 comments Download
M tools/ipc_fuzzer/fuzzer/generator.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M tools/ipc_fuzzer/fuzzer/mutator.h View 2 chunks +7 lines, -4 lines 0 comments Download
M tools/ipc_fuzzer/fuzzer/mutator.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M tools/ipc_fuzzer/fuzzer/rand_util.h View 2 chunks +9 lines, -7 lines 0 comments Download
M tools/ipc_fuzzer/fuzzer/rand_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/ipc_fuzzer/message_dump/message_dump.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/ipc_fuzzer/message_lib/message_cracker.h View 2 chunks +3 lines, -1 line 0 comments Download
M tools/ipc_fuzzer/message_lib/message_file.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/ipc_fuzzer/message_lib/message_file_format.h View 2 chunks +9 lines, -9 lines 0 comments Download
M tools/ipc_fuzzer/message_lib/message_file_reader.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M tools/ipc_fuzzer/message_lib/message_file_writer.cc View 2 chunks +4 lines, -1 line 0 comments Download
M tools/ipc_fuzzer/message_lib/message_names.h View 3 chunks +9 lines, -7 lines 0 comments Download
M tools/ipc_fuzzer/message_lib/message_names.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/ipc_fuzzer/message_replay/replay_process.h View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/ipc_fuzzer/message_replay/replay_process.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/ipc_fuzzer/message_tools/message_list.cc View 1 chunk +3 lines, -1 line 0 comments Download
M tools/ipc_fuzzer/message_tools/message_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/json_schema_compiler/test/arrays_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/test/choices_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/test/objects_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/perf/clear_system_cache/clear_system_cache_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/traceline/traceline/assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1538743002 Patch 220001
Issue 1538743002 Patch 240001

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549203002/1
4 years, 12 months ago (2015-12-26 05:03:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-26 07:00:48 UTC) #3
commit-bot: I haz the power
4 years, 12 months ago (2015-12-26 07:01:30 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cab0f83c7f6c4401bc59c8b797461b6a2f7b08e1
Cr-Commit-Position: refs/heads/master@{#366895}

Powered by Google App Engine
This is Rietveld 408576698