Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

Issue 1549153002: Fix preferred logical widths of orthogonal writing modes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: leviw review Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
index 491f7a8af2b8332511ba74428a2479dfd93a63ed..a62c97d0745eba68bcedfd7215f39e9c64c0cf5c 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
@@ -375,16 +375,6 @@ inline bool LayoutBlockFlow::layoutBlockFlow(bool relayoutChildren, LayoutUnit &
else
layoutBlockChildren(relayoutChildren, layoutScope, beforeEdge, afterEdge);
- if (needsRecalcLogicalWidthAfterLayoutChildren()) {
- // In perpendicular writing-mode, min-content logicalWidth depends on the child's logicalHeight,
- // so logicalWidth needs to be updated after children layout is done.
- // Strictly speaking, children need re-layout if logicalWidth is changed, but in most cases,
- // perpendicular children do not re-flow according to parent's logicalWidth.
- clearNeedsRecalcLogicalWidthAfterLayoutChildren();
- setPreferredLogicalWidthsDirty(MarkOnlyThis);
- updateLogicalWidthAndColumnWidth();
- }
-
// Expand our intrinsic height to encompass floats.
if (lowestFloatLogicalBottom() > (logicalHeight() - afterEdge) && createsNewFormattingContext())
setLogicalHeight(lowestFloatLogicalBottom() + afterEdge);
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlock.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBox.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698