third_party/WebKit/Source/core/layout/LayoutBox.h - Issue 1549153002: Fix preferred logical widths of orthogonal writing modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 1549153002: Fix preferred logical widths of orthogonal writing modes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Allow call to remove() while iterating as long as it doesn't actually remove Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/DepthOrderedLayoutObjectList.h ('K') | « third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBox.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h b/third_party/WebKit/Source/core/layout/LayoutBox.h

index 2dd9f946f312fc51eb137ed7250b1c6e85d614d8..441012e2c156c424da07c38f8a444557b9cf3c16 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h

@@ -751,6 +751,9 @@ public:

virtual void markForPaginationRelayoutIfNeeded(SubtreeLayoutScope&);

bool isWritingModeRoot() const { return !parent() || parent()->style()->writingMode() != style()->writingMode(); }

+ bool isOrthogonalWritingModeRoot() const { return parent() && parent()->isHorizontalWritingMode() != isHorizontalWritingMode(); }

+ void markOrthogonalWritingModeRoot();

+ void unmarkOrthogonalWritingModeRoot();

bool isDeprecatedFlexItem() const { return !isInline() && !isFloatingOrOutOfFlowPositioned() && parent() && parent()->isDeprecatedFlexibleBox(); }

bool isFlexItemIncludingDeprecated() const { return !isInline() && !isFloatingOrOutOfFlowPositioned() && parent() && parent()->isFlexibleBoxIncludingDeprecated(); }

@@ -879,6 +882,9 @@ public:

protected:

void willBeDestroyed() override;

+ void insertedIntoTree() override;

+ void willBeRemovedFromTree() override;

void styleWillChange(StyleDifference, const ComputedStyle& newStyle) override;

void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override;

void updateFromStyle() override;