third_party/WebKit/Source/core/layout/LayoutBlock.h - Issue 1549153002: Fix preferred logical widths of orthogonal writing modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 1549153002: Fix preferred logical widths of orthogonal writing modes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase (merge conflict resolved) Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/DepthOrderedLayoutObjectList.h ('K') | « third_party/WebKit/Source/core/layout/DepthOrderedLayoutObjectList.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBlock.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.h b/third_party/WebKit/Source/core/layout/LayoutBlock.h

index 10a6df4ca84190fa68860f875619bc80fd6a22f3..1d87901e6e1a8510b8c4a4627dc43300264abc5e 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.h

@@ -256,10 +256,6 @@ public:

LayoutUnit startOffsetForContent() const { return style()->isLeftToRightDirection() ? logicalLeftOffsetForContent() : logicalWidth() - logicalRightOffsetForContent(); }

LayoutUnit endOffsetForContent() const { return !style()->isLeftToRightDirection() ? logicalLeftOffsetForContent() : logicalWidth() - logicalRightOffsetForContent(); }

- bool needsRecalcLogicalWidthAfterLayoutChildren() const { return m_needsRecalcLogicalWidthAfterLayoutChildren; }

- void setNeedsRecalcLogicalWidthAfterLayoutChildren() { m_needsRecalcLogicalWidthAfterLayoutChildren = true; }

- void clearNeedsRecalcLogicalWidthAfterLayoutChildren() { m_needsRecalcLogicalWidthAfterLayoutChildren = false; }

virtual LayoutUnit logicalLeftSelectionOffset(const LayoutBlock* rootBlock, LayoutUnit position) const;

virtual LayoutUnit logicalRightSelectionOffset(const LayoutBlock* rootBlock, LayoutUnit position) const;

@@ -491,7 +487,6 @@ protected:

unsigned m_widthAvailableToChildrenChanged : 1;

mutable unsigned m_hasOnlySelfCollapsingChildren : 1;

mutable unsigned m_descendantsWithFloatsMarkedForLayout : 1;

- mutable unsigned m_needsRecalcLogicalWidthAfterLayoutChildren : 1;

unsigned m_hasPositionedObjects : 1;

unsigned m_hasPercentHeightDescendants : 1;