third_party/WebKit/Source/core/frame/LayoutSubtreeRootList.cpp - Issue 1549153002: Fix preferred logical widths of orthogonal writing modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LayoutSubtreeRootList.cpp

Issue 1549153002: Fix preferred logical widths of orthogonal writing modes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TestExpectations Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/FrameView.cpp ('K') | « third_party/WebKit/Source/core/frame/LayoutSubtreeRootList.h ('k') | third_party/WebKit/Source/core/frame/OrthogonalWritingModeRootList.h » ('j') | third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/LayoutSubtreeRootList.cpp

diff --git a/third_party/WebKit/Source/core/frame/LayoutSubtreeRootList.cpp b/third_party/WebKit/Source/core/frame/LayoutSubtreeRootList.cpp

index 43a606378047e8f73bd025479ab228610a6095fe..35979a40df8f340a459655b8f15cf994e612006e 100644

--- a/third_party/WebKit/Source/core/frame/LayoutSubtreeRootList.cpp

+++ b/third_party/WebKit/Source/core/frame/LayoutSubtreeRootList.cpp

@@ -10,14 +10,6 @@

namespace blink {

-unsigned LayoutSubtreeRootList::LayoutSubtree::determineDepth(LayoutObject* object)

- unsigned depth = 1;

- for (LayoutObject* parent = object->parent(); parent; parent = parent->parent())

- ++depth;

- return depth;

void LayoutSubtreeRootList::removeRoot(LayoutObject& object)

{

if (!m_roots.isEmpty()) {