Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 1549153002: Fix preferred logical widths of orthogonal writing modes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: TestExpectations Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 711 matching lines...) Expand 10 before | Expand all | Expand 10 after
722 722
723 virtual int firstLineBoxBaseline() const { return -1; } 723 virtual int firstLineBoxBaseline() const { return -1; }
724 virtual int inlineBlockBaseline(LineDirectionMode) const { return -1; } // R eturns -1 if we should skip this box when computing the baseline of an inline-bl ock. 724 virtual int inlineBlockBaseline(LineDirectionMode) const { return -1; } // R eturns -1 if we should skip this box when computing the baseline of an inline-bl ock.
725 725
726 bool shrinkToAvoidFloats() const; 726 bool shrinkToAvoidFloats() const;
727 virtual bool avoidsFloats() const; 727 virtual bool avoidsFloats() const;
728 728
729 virtual void markForPaginationRelayoutIfNeeded(SubtreeLayoutScope&); 729 virtual void markForPaginationRelayoutIfNeeded(SubtreeLayoutScope&);
730 730
731 bool isWritingModeRoot() const { return !parent() || parent()->style()->writ ingMode() != style()->writingMode(); } 731 bool isWritingModeRoot() const { return !parent() || parent()->style()->writ ingMode() != style()->writingMode(); }
732 bool isOrthogonalWritingModeRoot() const { return parent() && parent()->isHo rizontalWritingMode() != isHorizontalWritingMode(); }
733 void markOrthogonalWritingModeRoot();
734 void unmarkOrthogonalWritingModeRoot();
732 735
733 bool isDeprecatedFlexItem() const { return !isInline() && !isFloatingOrOutOf FlowPositioned() && parent() && parent()->isDeprecatedFlexibleBox(); } 736 bool isDeprecatedFlexItem() const { return !isInline() && !isFloatingOrOutOf FlowPositioned() && parent() && parent()->isDeprecatedFlexibleBox(); }
734 bool isFlexItemIncludingDeprecated() const { return !isInline() && !isFloati ngOrOutOfFlowPositioned() && parent() && parent()->isFlexibleBoxIncludingDepreca ted(); } 737 bool isFlexItemIncludingDeprecated() const { return !isInline() && !isFloati ngOrOutOfFlowPositioned() && parent() && parent()->isFlexibleBoxIncludingDepreca ted(); }
735 738
736 bool isGridItem() const { return parent() && parent()->isLayoutGrid(); } 739 bool isGridItem() const { return parent() && parent()->isLayoutGrid(); }
737 740
738 LayoutUnit lineHeight(bool firstLine, LineDirectionMode, LinePositionMode = PositionOnContainingLine) const override; 741 LayoutUnit lineHeight(bool firstLine, LineDirectionMode, LinePositionMode = PositionOnContainingLine) const override;
739 int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode, LinePo sitionMode = PositionOnContainingLine) const override; 742 int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode, LinePo sitionMode = PositionOnContainingLine) const override;
740 743
741 LayoutUnit offsetLeft() const override; 744 LayoutUnit offsetLeft() const override;
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
845 bool canRenderBorderImage() const; 848 bool canRenderBorderImage() const;
846 849
847 void mapLocalToContainer(const LayoutBoxModelObject* paintInvalidationContai ner, TransformState&, MapCoordinatesFlags = ApplyContainerFlip, bool* wasFixed = nullptr, const PaintInvalidationState* = nullptr) const override; 850 void mapLocalToContainer(const LayoutBoxModelObject* paintInvalidationContai ner, TransformState&, MapCoordinatesFlags = ApplyContainerFlip, bool* wasFixed = nullptr, const PaintInvalidationState* = nullptr) const override;
848 void mapAbsoluteToLocalPoint(MapCoordinatesFlags, TransformState&) const ove rride; 851 void mapAbsoluteToLocalPoint(MapCoordinatesFlags, TransformState&) const ove rride;
849 852
850 void clearPreviousPaintInvalidationRects() override; 853 void clearPreviousPaintInvalidationRects() override;
851 854
852 protected: 855 protected:
853 void willBeDestroyed() override; 856 void willBeDestroyed() override;
854 857
858 void insertedIntoTree() override;
859 void willBeRemovedFromTree() override;
860
855 void styleWillChange(StyleDifference, const ComputedStyle& newStyle) overrid e; 861 void styleWillChange(StyleDifference, const ComputedStyle& newStyle) overrid e;
856 void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override ; 862 void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override ;
857 void updateFromStyle() override; 863 void updateFromStyle() override;
858 864
859 // Returns false if it could not cheaply compute the extent (e.g. fixed back ground), in which case the returned rect may be incorrect. 865 // Returns false if it could not cheaply compute the extent (e.g. fixed back ground), in which case the returned rect may be incorrect.
860 // FIXME: make this a const method once the LayoutBox reference in BoxPainte r is const. 866 // FIXME: make this a const method once the LayoutBox reference in BoxPainte r is const.
861 bool getBackgroundPaintedExtent(LayoutRect&) const; 867 bool getBackgroundPaintedExtent(LayoutRect&) const;
862 virtual bool foregroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect, unsigned maxDepthToTest) const; 868 virtual bool foregroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect, unsigned maxDepthToTest) const;
863 bool computeBackgroundIsKnownToBeObscured() const override; 869 bool computeBackgroundIsKnownToBeObscured() const override;
864 870
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
1067 if (UNLIKELY(inlineBoxWrapper() != nullptr)) 1073 if (UNLIKELY(inlineBoxWrapper() != nullptr))
1068 deleteLineBoxWrapper(); 1074 deleteLineBoxWrapper();
1069 } 1075 }
1070 1076
1071 ensureRareData().m_inlineBoxWrapper = boxWrapper; 1077 ensureRareData().m_inlineBoxWrapper = boxWrapper;
1072 } 1078 }
1073 1079
1074 } // namespace blink 1080 } // namespace blink
1075 1081
1076 #endif // LayoutBox_h 1082 #endif // LayoutBox_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698