Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: content/browser/accessibility/browser_accessibility_win.h

Issue 1549113002: Switch to standard integer types in content/browser/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_win.h
diff --git a/content/browser/accessibility/browser_accessibility_win.h b/content/browser/accessibility/browser_accessibility_win.h
index c51d1d44852c73dbb6b11a039998bd04f37a6be9..18924ac2f6eccd0fa8ba83b5bc95b92c2d40963f 100644
--- a/content/browser/accessibility/browser_accessibility_win.h
+++ b/content/browser/accessibility/browser_accessibility_win.h
@@ -8,12 +8,15 @@
#include <atlbase.h>
#include <atlcom.h>
#include <oleacc.h>
+#include <stddef.h>
+#include <stdint.h>
#include <UIAutomationCore.h>
#include <vector>
#include "base/compiler_specific.h"
#include "base/gtest_prod_util.h"
+#include "base/macros.h"
#include "content/browser/accessibility/browser_accessibility.h"
#include "content/common/content_export.h"
#include "third_party/iaccessible2/ia2_api_all.h"
@@ -87,8 +90,8 @@ BrowserAccessibilityWin
// Mappings from roles and states to human readable strings. Initialize
// with |InitializeStringMaps|.
- static std::map<int32, base::string16> role_string_map;
- static std::map<int32, base::string16> state_string_map;
+ static std::map<int32_t, base::string16> role_string_map;
+ static std::map<int32_t, base::string16> state_string_map;
CONTENT_EXPORT BrowserAccessibilityWin();
@@ -711,11 +714,11 @@ BrowserAccessibilityWin
void** object);
// Accessors.
- int32 ia_role() const { return win_attributes_->ia_role; }
- int32 ia_state() const { return win_attributes_->ia_state; }
+ int32_t ia_role() const { return win_attributes_->ia_role; }
+ int32_t ia_state() const { return win_attributes_->ia_state; }
const base::string16& role_name() const { return win_attributes_->role_name; }
- int32 ia2_role() const { return win_attributes_->ia2_role; }
- int32 ia2_state() const { return win_attributes_->ia2_state; }
+ int32_t ia2_role() const { return win_attributes_->ia2_role; }
+ int32_t ia2_state() const { return win_attributes_->ia2_state; }
const std::vector<base::string16>& ia2_attributes() const {
return win_attributes_->ia2_attributes;
}
@@ -723,10 +726,12 @@ BrowserAccessibilityWin
base::string16 description() const { return win_attributes_->description; }
base::string16 value() const { return win_attributes_->value; }
base::string16 hypertext() const { return win_attributes_->hypertext; }
- std::map<int32, int32>& hyperlink_offset_to_index() const {
+ std::map<int32_t, int32_t>& hyperlink_offset_to_index() const {
return win_attributes_->hyperlink_offset_to_index;
}
- std::vector<int32>& hyperlinks() const { return win_attributes_->hyperlinks; }
+ std::vector<int32_t>& hyperlinks() const {
+ return win_attributes_->hyperlinks;
+ }
private:
// Add one to the reference count and return the same object. Always
@@ -787,10 +792,12 @@ BrowserAccessibilityWin
// Functions for retrieving offsets for hyperlinks and hypertext.
// Return -1 in case of failure.
- int32 GetHyperlinkIndexFromChild(const BrowserAccessibilityWin& child) const;
- int32 GetHypertextOffsetFromHyperlinkIndex(int32 hyperlink_index) const;
- int32 GetHypertextOffsetFromChild(const BrowserAccessibilityWin& child) const;
- int32 GetHypertextOffsetFromDescendant(
+ int32_t GetHyperlinkIndexFromChild(
+ const BrowserAccessibilityWin& child) const;
+ int32_t GetHypertextOffsetFromHyperlinkIndex(int32_t hyperlink_index) const;
+ int32_t GetHypertextOffsetFromChild(
+ const BrowserAccessibilityWin& child) const;
+ int32_t GetHypertextOffsetFromDescendant(
const BrowserAccessibilityWin& descendant) const;
// If the selection endpoint is either equal to or an ancestor of this object,
@@ -845,7 +852,7 @@ BrowserAccessibilityWin
// Return a pointer to the object corresponding to the given id,
// does not make a new reference.
- BrowserAccessibilityWin* GetFromID(int32 id);
+ BrowserAccessibilityWin* GetFromID(int32_t id);
// Returns true if this is a list box option with a parent of type list box,
// or a menu list option with a parent of type menu list popup.
@@ -869,8 +876,8 @@ BrowserAccessibilityWin
~WinAttributes();
// IAccessible role and state.
- int32 ia_role;
- int32 ia_state;
+ int32_t ia_role;
+ int32_t ia_state;
base::string16 role_name;
// IAccessible name, description, help, value.
@@ -879,8 +886,8 @@ BrowserAccessibilityWin
base::string16 value;
// IAccessible2 role and state.
- int32 ia2_role;
- int32 ia2_state;
+ int32_t ia2_role;
+ int32_t ia2_state;
// IAccessible2 attributes.
std::vector<base::string16> ia2_attributes;
@@ -890,11 +897,11 @@ BrowserAccessibilityWin
// Maps the |hypertext_| embedded character offset to an index in
// |hyperlinks_|.
- std::map<int32, int32> hyperlink_offset_to_index;
+ std::map<int32_t, int32_t> hyperlink_offset_to_index;
// The id of a BrowserAccessibilityWin for each hyperlink.
// TODO(nektar): Replace object IDs with child indices.
- std::vector<int32> hyperlinks;
+ std::vector<int32_t> hyperlinks;
};
scoped_ptr<WinAttributes> win_attributes_;

Powered by Google App Engine
This is Rietveld 408576698