Rename PPB_Flash_DeviceID interface to PPB_Flash_DRM

Rename PPB_Flash_DeviceID interface to PPB_Flash_DRM

This is mainly a mechanical change to rename PPB_Flash_DeviceID to PPB_Flash_DRM. It deprecates the old interface. The reason is that we will be adding more DRM-related APIs and it makes sense to put them into a single interface.

BUG=242241
TBR=brettw for chrome_browser.gypi

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202286

[raymes, 2013-05-20 21:34:44]

We will have to notify Adobe before comitting this CL so that when they roll
pepper, they change their C++ wrappers to use the new ones provided in this CL.
Alternatively I can include the old wrappers and have them switch over before
deleting them.

[yzshen1, 2013-05-21 06:32:31]

Only nits.

https://codereview.chromium.org/15491006/diff/5001/ppapi/api/private/ppb_flas...
File ppapi/api/private/ppb_flash_device_id.idl (right):

https://codereview.chromium.org/15491006/diff/5001/ppapi/api/private/ppb_flas...
ppapi/api/private/ppb_flash_device_id.idl:25: [version=1.0, deprecate=1.1]
I don't see why this (and line 12) is necessary. It doesn't change anything in
the generated .h file, right?

https://codereview.chromium.org/15491006/diff/5001/ppapi/api/private/ppb_flas...
File ppapi/api/private/ppb_flash_drm.idl (right):

https://codereview.chromium.org/15491006/diff/5001/ppapi/api/private/ppb_flas...
ppapi/api/private/ppb_flash_drm.idl:21: * Create a PPB_Flash_DRM resource for
performing DRM-related operations in
Create -> Creates

https://codereview.chromium.org/15491006/diff/5001/ppapi/cpp/private/flash_dr...
File ppapi/cpp/private/flash_drm.cc (right):

https://codereview.chromium.org/15491006/diff/5001/ppapi/cpp/private/flash_dr...
ppapi/cpp/private/flash_drm.cc:47: } else if
(has_interface<PPB_Flash_DeviceID_1_0>()) {
The way that our style guide prefers: remove the 'else'.

https://codereview.chromium.org/15491006/diff/5001/ppapi/cpp/private/flash_drm.h
File ppapi/cpp/private/flash_drm.h (right):

https://codereview.chromium.org/15491006/diff/5001/ppapi/cpp/private/flash_dr...
ppapi/cpp/private/flash_drm.h:17: DRM(const InstanceHandle& instance);
explicit?

https://codereview.chromium.org/15491006/diff/5001/ppapi/proxy/flash_drm_reso...
File ppapi/proxy/flash_drm_resource.cc (right):

https://codereview.chromium.org/15491006/diff/5001/ppapi/proxy/flash_drm_reso...
ppapi/proxy/flash_drm_resource.cc:26: FlashDRMResource::AsPPB_Flash_DRM_API() {
I guess we don't have to wrap now. (But I didn't actually count the char number.
:))

https://codereview.chromium.org/15491006/diff/5001/ppapi/proxy/flash_drm_reso...
ppapi/proxy/flash_drm_resource.cc:50: if (params.result() == PP_OK)
Please check whether callback is pending. If not, we should not touch |dest|.
The plugin may have released the memory.

https://codereview.chromium.org/15491006/diff/5001/ppapi/proxy/flash_drm_reso...
File ppapi/proxy/flash_drm_resource.h (right):

https://codereview.chromium.org/15491006/diff/5001/ppapi/proxy/flash_drm_reso...
ppapi/proxy/flash_drm_resource.h:21: PP_Instance instance);
wrong indent.

[raymes, 2013-05-21 16:32:51]

Thanks. I decided to keep the Device ID cc files for now and remove them after
Adobe tells me they have switched over.

https://codereview.chromium.org/15491006/diff/5001/ppapi/api/private/ppb_flas...
File ppapi/api/private/ppb_flash_device_id.idl (right):

https://codereview.chromium.org/15491006/diff/5001/ppapi/api/private/ppb_flas...
ppapi/api/private/ppb_flash_device_id.idl:25: [version=1.0, deprecate=1.1]
No, I did this more for documentation. And if someone tried to add a new version
to this interface, it would have an affect.

https://codereview.chromium.org/15491006/diff/5001/ppapi/api/private/ppb_flas...
File ppapi/api/private/ppb_flash_drm.idl (right):

https://codereview.chromium.org/15491006/diff/5001/ppapi/api/private/ppb_flas...
ppapi/api/private/ppb_flash_drm.idl:21: * Create a PPB_Flash_DRM resource for
performing DRM-related operations in
On 2013/05/21 06:32:31, yzshen1 wrote:
> Create -> Creates

Done.

https://codereview.chromium.org/15491006/diff/5001/ppapi/cpp/private/flash_dr...
File ppapi/cpp/private/flash_drm.cc (right):

https://codereview.chromium.org/15491006/diff/5001/ppapi/cpp/private/flash_dr...
ppapi/cpp/private/flash_drm.cc:47: } else if
(has_interface<PPB_Flash_DeviceID_1_0>()) {
On 2013/05/21 06:32:31, yzshen1 wrote:
> The way that our style guide prefers: remove the 'else'.

Done.

https://codereview.chromium.org/15491006/diff/5001/ppapi/cpp/private/flash_drm.h
File ppapi/cpp/private/flash_drm.h (right):

https://codereview.chromium.org/15491006/diff/5001/ppapi/cpp/private/flash_dr...
ppapi/cpp/private/flash_drm.h:17: DRM(const InstanceHandle& instance);
On 2013/05/21 06:32:31, yzshen1 wrote:
> explicit?

Done.

https://codereview.chromium.org/15491006/diff/5001/ppapi/proxy/flash_drm_reso...
File ppapi/proxy/flash_drm_resource.cc (right):

https://codereview.chromium.org/15491006/diff/5001/ppapi/proxy/flash_drm_reso...
ppapi/proxy/flash_drm_resource.cc:26: FlashDRMResource::AsPPB_Flash_DRM_API() {
On 2013/05/21 06:32:31, yzshen1 wrote:
> I guess we don't have to wrap now. (But I didn't actually count the char
number.
> :))

Done.

https://codereview.chromium.org/15491006/diff/5001/ppapi/proxy/flash_drm_reso...
ppapi/proxy/flash_drm_resource.cc:50: if (params.result() == PP_OK)
On 2013/05/21 06:32:31, yzshen1 wrote:
> Please check whether callback is pending. If not, we should not touch |dest|.
> The plugin may have released the memory.

Done.

https://codereview.chromium.org/15491006/diff/5001/ppapi/proxy/flash_drm_reso...
File ppapi/proxy/flash_drm_resource.h (right):

https://codereview.chromium.org/15491006/diff/5001/ppapi/proxy/flash_drm_reso...
ppapi/proxy/flash_drm_resource.h:21: PP_Instance instance);
On 2013/05/21 06:32:31, yzshen1 wrote:
> wrong indent.

Done.

[yzshen1, 2013-05-21 16:48:45]

LGTM
Thanks!

https://codereview.chromium.org/15491006/diff/5001/ppapi/api/private/ppb_flas...
File ppapi/api/private/ppb_flash_device_id.idl (right):

https://codereview.chromium.org/15491006/diff/5001/ppapi/api/private/ppb_flas...
ppapi/api/private/ppb_flash_device_id.idl:25: [version=1.0, deprecate=1.1]
As long as you will remove this file entirely later, I am fine with that.
On 2013/05/21 16:32:51, raymes wrote:
> No, I did this more for documentation. And if someone tried to add a new
version
> to this interface, it would have an affect.

[commit-bot: I haz the power, 2013-05-22 15:40:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/15491006/14001

[raymes, 2013-05-22 15:44:14]

+tsepez for ppapi/proxy/ppapi_messages.h

It's a pure rename of the IPCs.

[raymes, 2013-05-22 15:44:30]

+tsepez for ppapi/proxy/ppapi_messages.h

It's a pure rename of the IPCs.

[Tom Sepez, 2013-05-22 16:57:08]

Rubberstamp LGTM on renaming messages.

[raymes, 2013-05-22 17:32:20]

TBR=brettw for chrome.gypi

[commit-bot: I haz the power, 2013-05-22 17:33:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/15491006/14001

[commit-bot: I haz the power, 2013-05-22 19:05:02]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-23 14:20:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/15491006/14001

[commit-bot: I haz the power, 2013-05-23 14:21:03]

Failed to apply patch for ppapi/c/pp_macros.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ppapi/c/pp_macros.h
  Hunk #1 FAILED at 3.
  1 out of 1 hunk FAILED -- saving rejects to file ppapi/c/pp_macros.h.rej

Patch:       ppapi/c/pp_macros.h
Index: ppapi/c/pp_macros.h
diff --git a/ppapi/c/pp_macros.h b/ppapi/c/pp_macros.h
index
6179380a351d5613af13995fcd1a2e8ee0825dfb..bcd740a841c9057ea93409b890a2559e926a19ad
100644
--- a/ppapi/c/pp_macros.h
+++ b/ppapi/c/pp_macros.h
@@ -3,13 +3,13 @@
  * found in the LICENSE file.
  */
 
-/* From pp_macros.idl modified Tue Mar 19 12:29:49 2013. */
+/* From pp_macros.idl modified Thu Mar 21 10:34:08 2013. */
 
 #ifndef PPAPI_C_PP_MACROS_H_
 #define PPAPI_C_PP_MACROS_H_
 
 
-#define PPAPI_RELEASE 28
+#define PPAPI_RELEASE 29
 
 /**
  * @file

[commit-bot: I haz the power, 2013-05-24 18:56:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/15491006/46001

[commit-bot: I haz the power, 2013-05-24 19:16:30]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-24 20:36:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/15491006/49004

[commit-bot: I haz the power, 2013-05-25 14:30:56]

Change committed as 202286