Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Side by Side Diff: base/strings/string_split_unittest.cc

Issue 1549063003: Don't unnecessarily copy strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/string_split.h" 5 #include "base/strings/string_split.h"
6 6
7 #include "base/strings/string_util.h" 7 #include "base/strings/string_util.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "testing/gmock/include/gmock/gmock.h" 9 #include "testing/gmock/include/gmock/gmock.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 std::vector<std::string> results; 258 std::vector<std::string> results;
259 SplitStringUsingSubstr( 259 SplitStringUsingSubstr(
260 "unDELIMITERdeuxDELIMITERtroisDELIMITERquatreDELIMITERDELIMITERDELIMITER", 260 "unDELIMITERdeuxDELIMITERtroisDELIMITERquatreDELIMITERDELIMITERDELIMITER",
261 "DELIMITER", 261 "DELIMITER",
262 &results); 262 &results);
263 ASSERT_EQ(7u, results.size()); 263 ASSERT_EQ(7u, results.size());
264 EXPECT_THAT( 264 EXPECT_THAT(
265 results, ElementsAre("un", "deux", "trois", "quatre", "", "", "")); 265 results, ElementsAre("un", "deux", "trois", "quatre", "", "", ""));
266 } 266 }
267 267
268 TEST(SplitStringPieceUsingSubstrTest, StringWithNoDelimiter) {
269 std::vector<base::StringPiece> results =
270 SplitStringPieceUsingSubstr("alongwordwithnodelimiter", "DELIMITER");
271 ASSERT_EQ(1u, results.size());
272 EXPECT_THAT(results, ElementsAre("alongwordwithnodelimiter"));
273 }
274
275 TEST(SplitStringPieceUsingSubstrTest, LeadingDelimitersSkipped) {
276 std::vector<base::StringPiece> results = SplitStringPieceUsingSubstr(
277 "DELIMITERDELIMITERDELIMITERoneDELIMITERtwoDELIMITERthree", "DELIMITER");
278 ASSERT_EQ(6u, results.size());
279 EXPECT_THAT(results, ElementsAre("", "", "", "one", "two", "three"));
280 }
281
282 TEST(SplitStringPieceUsingSubstrTest, ConsecutiveDelimitersSkipped) {
283 std::vector<base::StringPiece> results = SplitStringPieceUsingSubstr(
284 "unoDELIMITERDELIMITERDELIMITERdosDELIMITERtresDELIMITERDELIMITERcuatro",
285 "DELIMITER");
286 ASSERT_EQ(7u, results.size());
287 EXPECT_THAT(results, ElementsAre("uno", "", "", "dos", "tres", "", "cuatro"));
288 }
289
290 TEST(SplitStringPieceUsingSubstrTest, TrailingDelimitersSkipped) {
291 std::vector<base::StringPiece> results = SplitStringPieceUsingSubstr(
292 "unDELIMITERdeuxDELIMITERtroisDELIMITERquatreDELIMITERDELIMITERDELIMITER",
293 "DELIMITER");
294 ASSERT_EQ(7u, results.size());
295 EXPECT_THAT(results,
296 ElementsAre("un", "deux", "trois", "quatre", "", "", ""));
297 }
298
268 TEST(StringSplitTest, StringSplitKeepWhitespace) { 299 TEST(StringSplitTest, StringSplitKeepWhitespace) {
269 std::vector<std::string> r; 300 std::vector<std::string> r;
270 301
271 r = SplitString(" ", "*", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL); 302 r = SplitString(" ", "*", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
272 ASSERT_EQ(1U, r.size()); 303 ASSERT_EQ(1U, r.size());
273 EXPECT_EQ(r[0], " "); 304 EXPECT_EQ(r[0], " ");
274 305
275 r = SplitString("\t \ta\t ", "\t", base::KEEP_WHITESPACE, 306 r = SplitString("\t \ta\t ", "\t", base::KEEP_WHITESPACE,
276 base::SPLIT_WANT_ALL); 307 base::SPLIT_WANT_ALL);
277 ASSERT_EQ(4U, r.size()); 308 ASSERT_EQ(4U, r.size());
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 base::SPLIT_WANT_NONEMPTY); 345 base::SPLIT_WANT_NONEMPTY);
315 ASSERT_EQ(data[i].expected_result_count, results.size()); 346 ASSERT_EQ(data[i].expected_result_count, results.size());
316 if (data[i].expected_result_count > 0) 347 if (data[i].expected_result_count > 0)
317 ASSERT_EQ(data[i].output1, results[0]); 348 ASSERT_EQ(data[i].output1, results[0]);
318 if (data[i].expected_result_count > 1) 349 if (data[i].expected_result_count > 1)
319 ASSERT_EQ(data[i].output2, results[1]); 350 ASSERT_EQ(data[i].output2, results[1]);
320 } 351 }
321 } 352 }
322 353
323 } // namespace base 354 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698