Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1549063002: Switch DEPS for ICU from a deadend branch to the active one. (Closed)

Created:
5 years ago by Lei Zhang
Modified:
5 years ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch DEPS for ICU from a deadend branch to the active one. TBR=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d4192c7774dac4b2fb30facb3deb3453e03c88fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
TBR, matches the one from V8. It's actively been worked on, whereas the old checkout ...
5 years ago (2015-12-24 04:27:52 UTC) #1
Lei Zhang
Committed patchset #1 (id:1) manually as d4192c7774dac4b2fb30facb3deb3453e03c88fc (presubmit successful).
5 years ago (2015-12-24 04:28:43 UTC) #3
Lei Zhang
5 years ago (2015-12-24 04:28:57 UTC) #4
Message was sent while issue was closed. 
Too late, but s/deadend/dead end/

Powered by Google App Engine
This is Rietveld 408576698