Fix failed JPX image rendering

Fix failed JPX image rendering

BUG=pdfium:338
R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/f308885d1880bc0d9a6798512ef7c740550d08e9

[jun_fang, 2015-12-24 07:20:19]

jun_fang@foxitsoftware.com changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[jun_fang, 2015-12-24 07:20:19]

Hi Tom and Lei,

Please review this CL. Thanks!

[Lei Zhang, 2015-12-24 08:42:55]

lgtm

https://codereview.chromium.org/1549043003/diff/1/core/include/fxcodec/fx_cod...
File core/include/fxcodec/fx_codec.h (right):

https://codereview.chromium.org/1549043003/diff/1/core/include/fxcodec/fx_cod...
core/include/fxcodec/fx_codec.h:12: #include
"core/include/fpdfapi/fpdf_resource.h"
No need, just forward declare at line 17.

https://codereview.chromium.org/1549043003/diff/1/core/src/fxcodec/codec/fx_c...
File core/src/fxcodec/codec/fx_codec_jpx_opj.cpp (right):

https://codereview.chromium.org/1549043003/diff/1/core/src/fxcodec/codec/fx_c...
core/src/fxcodec/codec/fx_codec_jpx_opj.cpp:678: const CPDF_ColorSpace*
m_ColorSpace;
const CPDF_ColorSpace* const, since the pointer itself never changes.

[jun_fang, 2015-12-24 10:12:20]

https://codereview.chromium.org/1549043003/diff/1/core/include/fxcodec/fx_cod...
File core/include/fxcodec/fx_codec.h (right):

https://codereview.chromium.org/1549043003/diff/1/core/include/fxcodec/fx_cod...
core/include/fxcodec/fx_codec.h:12: #include
"core/include/fpdfapi/fpdf_resource.h"
On 2015/12/24 08:42:55, Lei Zhang wrote:
> No need, just forward declare at line 17.

Acknowledged.

https://codereview.chromium.org/1549043003/diff/1/core/src/fxcodec/codec/fx_c...
File core/src/fxcodec/codec/fx_codec_jpx_opj.cpp (right):

https://codereview.chromium.org/1549043003/diff/1/core/src/fxcodec/codec/fx_c...
core/src/fxcodec/codec/fx_codec_jpx_opj.cpp:678: const CPDF_ColorSpace*
m_ColorSpace;
On 2015/12/24 08:42:55, Lei Zhang wrote:
> const CPDF_ColorSpace* const, since the pointer itself never changes.

Acknowledged.

[jun_fang, 2015-12-24 10:13:46]

Description was changed from

==========
Fix failed JPX image rendering

BUG=pdfium:338
==========

to

==========
Fix failed JPX image rendering

BUG=pdfium:338
R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/f308885d1880bc0d9a6798512ef7c740550d...
==========

[jun_fang, 2015-12-24 10:13:49]

Committed patchset #2 (id:20001) manually as
f308885d1880bc0d9a6798512ef7c740550d08e9 (presubmit successful).