Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1549043002: Switch to standard integer types in base/debug/. (Closed)

Created:
4 years, 12 months ago by Avi (use Gerrit)
Modified:
4 years, 12 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to standard integer types in base/debug/. BUG=138542 TBR=mark@chromium.org NOPRESUBMIT=true Committed: https://crrev.com/ebe805c971bd41b5666c52adfc83ceabb5bde0ed Cr-Commit-Position: refs/heads/master@{#366815}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -25 lines) Patch
M base/debug/asan_invalid_access.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M base/debug/crash_logging.h View 1 chunk +3 lines, -1 line 0 comments Download
M base/debug/crash_logging_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/debug/debugger.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/debug/debugger_posix.cc View 2 chunks +2 lines, -1 line 0 comments Download
M base/debug/gdi_debug_util_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/debug/leak_annotations.h View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/leak_tracker.h View 1 chunk +2 lines, -0 lines 0 comments Download
M base/debug/proc_maps_linux.h View 2 chunks +3 lines, -2 lines 0 comments Download
M base/debug/proc_maps_linux.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M base/debug/proc_maps_linux_unittest.cc View 2 chunks +6 lines, -1 line 0 comments Download
M base/debug/profiler.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/debug/profiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/debug/stack_trace.h View 1 chunk +2 lines, -0 lines 0 comments Download
M base/debug/stack_trace.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/stack_trace_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/debug/stack_trace_posix.cc View 2 chunks +3 lines, -1 line 0 comments Download
M base/debug/stack_trace_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M base/debug/stack_trace_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/debug/task_annotator.h View 2 chunks +4 lines, -2 lines 0 comments Download
M base/debug/task_annotator.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549043002/1
4 years, 12 months ago (2015-12-24 04:24:57 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/131472)
4 years, 12 months ago (2015-12-24 04:33:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549043002/1
4 years, 12 months ago (2015-12-24 04:54:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/153344)
4 years, 12 months ago (2015-12-24 07:08:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549043002/1
4 years, 12 months ago (2015-12-24 07:15:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-24 08:21:01 UTC) #13
commit-bot: I haz the power
4 years, 12 months ago (2015-12-24 08:21:47 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ebe805c971bd41b5666c52adfc83ceabb5bde0ed
Cr-Commit-Position: refs/heads/master@{#366815}

Powered by Google App Engine
This is Rietveld 408576698