Issue 1548963004: Fix another regression from commit f6dafc9.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1548963004: Fix another regression from commit f6dafc9. (Closed)

Created:
4 years, 12 months ago by Lei Zhang

Modified:
4 years, 12 months ago

Reviewers:
Wei Li

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix another regression from commit f6dafc9. TBR=weili@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/b43b8859153e129053f3fa790c182fa04c3336db

Patch Set 1 #

Total comments: 1

Created: 4 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View		1 chunk	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lei Zhang

TBR https://codereview.chromium.org/1548963004/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (left): https://codereview.chromium.org/1548963004/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp#oldcode2979 core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:2979: objnum = pParser->m_ObjectInfo[objnum].pos; Changing a passed by value ...

4 years, 12 months ago (2015-12-25 05:12:21 UTC) #1

Lei Zhang

4 years, 12 months ago (2015-12-25 05:13:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b43b8859153e129053f3fa790c182fa04c3336db (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages