Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Issue 1548943002: GN: Add assert that //pdf is referenced only when enable_pdf=true (Closed)

Created:
5 years ago by agrieve
Modified:
4 years, 12 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Add assert that //pdf is referenced only when enable_pdf=true BUG= Committed: https://crrev.com/1b748a5398bae9ed77d802fc35bc4cbe6b1b2c1a Cr-Commit-Position: refs/heads/master@{#366981}

Patch Set 1 #

Patch Set 2 : import featrues.gni #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pdf/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
agrieve
5 years ago (2015-12-23 20:31:33 UTC) #2
Lei Zhang
lgtm
5 years ago (2015-12-24 04:02:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548943002/1
5 years ago (2015-12-24 04:03:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/30621) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years ago (2015-12-24 04:05:53 UTC) #7
Lei Zhang
Trybots went red. I think you need to import build/config/features.gni ?
5 years ago (2015-12-24 04:15:01 UTC) #8
agrieve
On 2015/12/24 04:15:01, Lei Zhang wrote: > Trybots went red. I think you need to ...
4 years, 12 months ago (2015-12-28 15:31:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548943002/20001
4 years, 12 months ago (2015-12-28 15:33:50 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 12 months ago (2015-12-28 16:16:28 UTC) #13
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 16:17:30 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1b748a5398bae9ed77d802fc35bc4cbe6b1b2c1a
Cr-Commit-Position: refs/heads/master@{#366981}

Powered by Google App Engine
This is Rietveld 408576698