Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: third_party/WebKit/Source/core/svg/SVGPathElement.cpp

Issue 1548933002: Don't give 'pathLength' semantic errors special treatment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Drop feConvolveMatrix[order] change. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/dom/svgpath-negative-pathLength-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGPathElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGPathElement.cpp b/third_party/WebKit/Source/core/svg/SVGPathElement.cpp
index b21d54b4fe04c914bab5a2e8d04a3417dcfb51dd..cd50481b90443be91a68f5f6586b9dacac2bc86a 100644
--- a/third_party/WebKit/Source/core/svg/SVGPathElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGPathElement.cpp
@@ -21,7 +21,6 @@
#include "core/svg/SVGPathElement.h"
#include "core/layout/svg/LayoutSVGPath.h"
-#include "core/svg/SVGDocumentExtensions.h"
#include "core/svg/SVGMPathElement.h"
#include "core/svg/SVGPathQuery.h"
#include "core/svg/SVGPathUtilities.h"
@@ -39,10 +38,8 @@ public:
SVGParsingError setBaseValueAsString(const String& value) override
{
SVGParsingError parseStatus = SVGAnimatedNumber::setBaseValueAsString(value);
-
- ASSERT(contextElement());
if (parseStatus == NoError && baseValue()->value() < 0)
- contextElement()->document().accessSVGExtensions().reportError("A negative value for path attribute <pathLength> is not allowed");
+ parseStatus = NegativeValueForbiddenError;
return parseStatus;
}
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/dom/svgpath-negative-pathLength-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698