Don't give 'pathLength' semantic errors special treatment

third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.cpp

Index: third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.cpp b/third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.cpp
index 4f7ecf2ab64956f6568428c002036fdeb4e0a89b..aaf414fd725e60ca0d8937053be832320ea86560 100644
--- a/third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.cpp
@@ -21,8 +21,6 @@
 
 #include "core/SVGNames.h"
 #include "core/dom/Document.h"
-#include "core/svg/SVGDocumentExtensions.h"
-#include "core/svg/SVGParserUtilities.h"
 #include "core/svg/graphics/filters/SVGFilterBuilder.h"
 #include "platform/geometry/FloatPoint.h"
 #include "platform/geometry/IntPoint.h"
@@ -61,12 +59,8 @@ protected:
 SVGParsingError SVGAnimatedOrder::setBaseValueAsString(const String& value)
 {
     SVGParsingError parseStatus = SVGAnimatedIntegerOptionalInteger::setBaseValueAsString(value);
-
-    ASSERT(contextElement());
-    if (parseStatus == NoError && (firstInteger()->baseValue()->value() < 1 || secondInteger()->baseValue()->value() < 1)) {
-        contextElement()->document().accessSVGExtensions().reportWarning(
-            "feConvolveMatrix: problem parsing order=\"" + value + "\".");
-    }
+    if (parseStatus == NoError && (firstInteger()->baseValue()->value() < 1 || secondInteger()->baseValue()->value() < 1))

[pdr., 2016/01/07 19:27:37]

Pedantic but it looks like a value of zero incorrectly result in a negative
value forbidden error.

Could you add a test of this too? Maybe just modify
svg/filters/feConvolveMatrix-error-handling.html?

[fs, 2016/01/07 20:03:50]

Hmm, this was just me being more blind than usual... These should indeed be > 0,
so I'll leave that for a later fix (and keep reportWarning around until then)
and try to remember to add the test at that point.

+        parseStatus = NegativeValueForbiddenError;
     return parseStatus;
 }