Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1548913002: Store a <scale, bias> tuple for textLength scale adjustment (Closed)

Created:
5 years ago by fs
Modified:
4 years, 11 months ago
Reviewers:
pdr.
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Store a <scale, bias> tuple for textLength scale adjustment SVGTextFragment::lengthAdjustTransform only ever has two values that could make it differ from the identity transform. By storing only these two values - and as floats rather than doubles - instead of the full AffineTransform, the size of SVGTextFragment is reduced by 40 bytes. To enable this we however need to store whether the writing-mode is vertical or horizontal, so steal one bit from the length field for that. BUG=571415 Committed: https://crrev.com/f34118c23eb1eb9f76cf34bf90e2f1ad81ad2339 Cr-Commit-Position: refs/heads/master@{#368051}

Patch Set 1 #

Patch Set 2 : Baseline. #

Total comments: 2

Patch Set 3 : Drop []. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -33 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextChunkBuilder.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextChunkBuilder.cpp View 5 chunks +10 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextFragment.h View 1 2 5 chunks +33 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
fs
5 years ago (2015-12-23 16:32:03 UTC) #2
pdr.
LGTM! https://codereview.chromium.org/1548913002/diff/20001/third_party/WebKit/Source/core/layout/svg/SVGTextFragment.h File third_party/WebKit/Source/core/layout/svg/SVGTextFragment.h (right): https://codereview.chromium.org/1548913002/diff/20001/third_party/WebKit/Source/core/layout/svg/SVGTextFragment.h#newcode140 third_party/WebKit/Source/core/layout/svg/SVGTextFragment.h:140: // T(x,y) * M(transform) [ * M(lengthAdjust) ] ...
4 years, 11 months ago (2016-01-04 21:54:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548913002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548913002/40001
4 years, 11 months ago (2016-01-07 10:23:12 UTC) #6
fs
https://codereview.chromium.org/1548913002/diff/20001/third_party/WebKit/Source/core/layout/svg/SVGTextFragment.h File third_party/WebKit/Source/core/layout/svg/SVGTextFragment.h (right): https://codereview.chromium.org/1548913002/diff/20001/third_party/WebKit/Source/core/layout/svg/SVGTextFragment.h#newcode140 third_party/WebKit/Source/core/layout/svg/SVGTextFragment.h:140: // T(x,y) * M(transform) [ * M(lengthAdjust) ] * ...
4 years, 11 months ago (2016-01-07 10:24:51 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-07 11:17:24 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 11:18:37 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f34118c23eb1eb9f76cf34bf90e2f1ad81ad2339
Cr-Commit-Position: refs/heads/master@{#368051}

Powered by Google App Engine
This is Rietveld 408576698