Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1548893002: Remove duplicate test data (Closed)

Created:
5 years ago by sangwoo
Modified:
4 years, 12 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicate test data InputType test has duplicate data, "host#ref", on line 86 and 88. modified: components/omnibox/browser/autocomplete_input_unittest.cc BUG=571771 Committed: https://crrev.com/573525c10a20c8b19b320c9153dc4467c3f3c769 Cr-Commit-Position: refs/heads/master@{#366982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M components/omnibox/browser/autocomplete_input_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
sangwoo
4 years, 12 months ago (2015-12-26 07:29:37 UTC) #3
Peter Kasting
lgtm
4 years, 12 months ago (2015-12-28 15:57:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548893002/1
4 years, 12 months ago (2015-12-28 15:57:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 16:33:34 UTC) #8
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 16:34:51 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/573525c10a20c8b19b320c9153dc4467c3f3c769
Cr-Commit-Position: refs/heads/master@{#366982}

Powered by Google App Engine
This is Rietveld 408576698