third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp - Issue 1548883002: Revert of Run smooth scroll animations on the compositor when possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp

Issue 1548883002: Revert of Run smooth scroll animations on the compositor when possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h ('k') | third_party/WebKit/Source/platform/scroll/ScrollAnimator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp b/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp

index 695718ddd33e28c9bddcf78fb6e97fb984b9d00d..f4a0af17641114168a3acfc23552c684be800f1c 100644

--- a/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp

@@ -63,12 +63,6 @@

notifyPositionChanged(IntPoint(offset.x(), offset.y()));

}

m_runState = RunState::WaitingToSendToCompositor;

-void ProgrammaticScrollAnimator::cancelAnimation()

- ASSERT(m_runState != RunState::RunningOnCompositorButNeedsUpdate);

- ScrollAnimatorCompositorCoordinator::cancelAnimation();

}

void ProgrammaticScrollAnimator::tickAnimation(double monotonicTime)

@@ -161,7 +155,6 @@

void ProgrammaticScrollAnimator::notifyCompositorAnimationFinished(int groupId)

{

- ASSERT(m_runState != RunState::RunningOnCompositorButNeedsUpdate);

ScrollAnimatorCompositorCoordinator::compositorAnimationFinished(groupId);

}