Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1548793002: dart2js: format 'static' sections better. (Closed)

Created:
5 years ago by sra1
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: format 'static' sections better. Unminified: each property goes on a new line. minified: ignore the isOneLiner directive until a function is seen. This makes unminified static functions easier to read, and makes minified swarm 0.3% smaller (but almost no different after gzip). R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/db2d6b798fa08f497faec2e89ed2f4413aa8f890

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/js_ast/lib/src/printer.dart View 1 chunk +12 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
5 years ago (2015-12-22 22:10:56 UTC) #2
Siggi Cherem (dart-lang)
lgtm
5 years ago (2015-12-22 22:38:12 UTC) #3
sra1
5 years ago (2015-12-22 22:45:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
db2d6b798fa08f497faec2e89ed2f4413aa8f890 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698