Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Side by Side Diff: src/hydrogen.cc

Issue 154873002: Explicitly disallow stores to JSObjectAccessors (for now). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5424 matching lines...) Expand 10 before | Expand all | Expand 10 after
5435 map->LookupDescriptor(*holder_, *name_, &lookup_); 5435 map->LookupDescriptor(*holder_, *name_, &lookup_);
5436 if (lookup_.IsFound()) return LoadResult(map); 5436 if (lookup_.IsFound()) return LoadResult(map);
5437 } 5437 }
5438 lookup_.NotFound(); 5438 lookup_.NotFound();
5439 return true; 5439 return true;
5440 } 5440 }
5441 5441
5442 5442
5443 bool HOptimizedGraphBuilder::PropertyAccessInfo::CanAccessMonomorphic() { 5443 bool HOptimizedGraphBuilder::PropertyAccessInfo::CanAccessMonomorphic() {
5444 if (!CanInlinePropertyAccess(type_)) return false; 5444 if (!CanInlinePropertyAccess(type_)) return false;
5445 if (IsJSObjectFieldAccessor()) { 5445 if (IsJSObjectFieldAccessor()) return IsLoad();
5446 // We should never have gathered typefeedback for JSObjectFieldAccessor
5447 // stores.
5448 ASSERT(IsLoad());
5449 return true;
5450 }
5451 if (!LookupDescriptor()) return false; 5446 if (!LookupDescriptor()) return false;
5452 if (lookup_.IsFound()) { 5447 if (lookup_.IsFound()) {
5453 if (IsLoad()) return true; 5448 if (IsLoad()) return true;
5454 return !lookup_.IsReadOnly() && lookup_.IsCacheable(); 5449 return !lookup_.IsReadOnly() && lookup_.IsCacheable();
5455 } 5450 }
5456 if (!LookupInPrototypes()) return false; 5451 if (!LookupInPrototypes()) return false;
5457 if (IsLoad()) return true; 5452 if (IsLoad()) return true;
5458 5453
5459 if (lookup_.IsPropertyCallbacks()) return true; 5454 if (lookup_.IsPropertyCallbacks()) return true;
5460 Handle<Map> map = this->map(); 5455 Handle<Map> map = this->map();
(...skipping 5766 matching lines...) Expand 10 before | Expand all | Expand 10 after
11227 if (ShouldProduceTraceOutput()) { 11222 if (ShouldProduceTraceOutput()) {
11228 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 11223 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
11229 } 11224 }
11230 11225
11231 #ifdef DEBUG 11226 #ifdef DEBUG
11232 graph_->Verify(false); // No full verify. 11227 graph_->Verify(false); // No full verify.
11233 #endif 11228 #endif
11234 } 11229 }
11235 11230
11236 } } // namespace v8::internal 11231 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698