Autocheckout: parse multiple clicks setting in autofill response.

components/autofill/browser/autocheckout_page_meta_data.h

Index: components/autofill/browser/autocheckout_page_meta_data.h
diff --git a/components/autofill/browser/autocheckout_page_meta_data.h b/components/autofill/browser/autocheckout_page_meta_data.h
index f1b9a7ad059200c5779071dbdedcc46ec2a9c06a..4b0cc1082f3ca6c5584517f5ac5e2b0758b211a7 100644
--- a/components/autofill/browser/autocheckout_page_meta_data.h
+++ b/components/autofill/browser/autocheckout_page_meta_data.h
@@ -5,6 +5,8 @@
 #ifndef COMPONENTS_AUTOFILL_BROWSER_AUTOCHECKOUT_PAGE_META_DATA_H_
 #define COMPONENTS_AUTOFILL_BROWSER_AUTOCHECKOUT_PAGE_META_DATA_H_
 
+#include <vector>
+
 #include "base/basictypes.h"
 #include "components/autofill/common/web_element_descriptor.h"
 
@@ -36,6 +38,15 @@ struct AutocheckoutPageMetaData {
   // belong to any autofill flow, it is set to -1.
   int total_pages;
 
+  // A list of elements to click before filling form fields.
+  // Elements have to be clicked in order, and may wait between clicks.

[Ilya Sherman, 2013/05/23 09:04:42]

nit: No waiting.

[benquan, 2013/05/24 00:45:11]

Done.

+  std::vector<WebElementDescriptor> click_elements_before_formfill;

[Ilya Sherman, 2013/05/23 09:04:42]

nit: "formfill" -> "form_fill" or something like that

[benquan, 2013/05/24 00:45:11]

Done.

+
+  // A list of elements to click after filling form fields, and before clicking
+  // page_advance_button.

[Ilya Sherman, 2013/05/23 09:04:42]

Why not just make the page_advance_button always be the last element that needs
to be clicked after filling the form?

[benquan, 2013/05/24 00:45:11]

page_advance_button is already in the proto and our fieldmapping files. We could
deprecate it and use this instead later.

[Ilya Sherman, 2013/05/31 23:14:49]

That affects parsing the XML, but not the structure of the
AutocheckoutPageMetaData class.

[benquan, 2013/06/01 01:08:39]

We do expect page navigation when click on page_advance_button, if it doesn't we
report an error. Oppositely, we do not expect page navigation when click
elements in click_elements_after_formfill. 

If the merchant has no separated checkout confirm page, we may need to fill
forms, and click some elements, but we do not proceed the page, if we add
proceed_element_descriptor to be the last element in
click_elements_after_formfill, we should have another flag to tell if the last
element should proceed to next step.

[Ilya Sherman, 2013/06/01 01:22:59]

Hmm, fair enough.  Please add this explanation to the documentation, so that
somebody like me doesn't come along later and try to refactor the
|page_advance_button_| away.

[benquan, 2013/06/03 17:55:22]

Done.

+  // Elements have to be clicked in order, and may wait between clicks.

[Ilya Sherman, 2013/05/23 09:04:42]

nit: No waiting.

[benquan, 2013/05/24 00:45:11]

Done.

+  std::vector<WebElementDescriptor> click_elements_after_formfill;

[Ilya Sherman, 2013/05/23 09:04:42]

nit: "formfill" -> "form_fill" or something like that

[benquan, 2013/05/24 00:45:11]

Done.

+
   // The proceed element of the multipage Autofill flow. It can be empty
   // if current page is the last page of a flow or isn't a member of a flow.
   WebElementDescriptor proceed_element_descriptor;