Autocheckout: parse multiple clicks setting in autofill response.

components/autofill/browser/autocheckout_page_meta_data.h

Index: components/autofill/browser/autocheckout_page_meta_data.h
diff --git a/components/autofill/browser/autocheckout_page_meta_data.h b/components/autofill/browser/autocheckout_page_meta_data.h
index f1b9a7ad059200c5779071dbdedcc46ec2a9c06a..2802309c7071292aa4f0fb72062d0cb39d5dd9cf 100644
--- a/components/autofill/browser/autocheckout_page_meta_data.h
+++ b/components/autofill/browser/autocheckout_page_meta_data.h
@@ -5,6 +5,8 @@
 #ifndef COMPONENTS_AUTOFILL_BROWSER_AUTOCHECKOUT_PAGE_META_DATA_H_
 #define COMPONENTS_AUTOFILL_BROWSER_AUTOCHECKOUT_PAGE_META_DATA_H_
 
+#include <vector>
+
 #include "base/basictypes.h"
 #include "components/autofill/common/web_element_descriptor.h"
 
@@ -12,6 +14,14 @@ namespace autofill {
 
 // Container for multipage Autocheckout data.
 struct AutocheckoutPageMetaData {
+  struct ClickElement{
+    WebElementDescriptor web_element;
+    // The time to wait after click the element which gives merchant's script a
+    // chance to execute. Usually we do not need to wait, but set it wisely if
+    // it is required.
+    int wait_time_ms;

[Ilya Sherman, 2013/05/21 04:25:04]

How are the times chosen?  What guarantees that the merchant's script will
complete in any specific amount of time?  The time required for the script to
run seems like it would depend a lot on the user's hardware and the load on that
hardware...

[benquan, 2013/05/21 17:17:08]

You are absolutely correct, the time required to complete merchant's script
depends on many factors, and there is no easy and clean way to detect that. So
we have to set it conservatively so that it covers majority of the users.

But, in the majority of the sites, we do not need to set a wait_time at all. If
we do need it for a few sites, I would expect merchant's script just simply
show/hide or enable/disable some DOM objects that are already loaded in the
page, it should be relatively quick. If the merchant use AJAX to bring in new
forms, we treats them as a new Autocheckout page, and query autofill server for
autofill-info for the new form, and thus a new AutocheckoutPageMetaData will be
retrieved, so wait_time_ms is not required.

[Ilya Sherman, 2013/05/21 22:48:41]

By this, you mean that for the majority of the sites, this entire CL is unneeded
-- right?
Let me reiterate: Relying on hardcoded timeouts is flaky (because even a
conservative setting will not cover all users) and slow (because a conservative
setting implies a lot of wasted time for most users).  We should block on
explicit DOM events instead, or find some other deterministic way to identify
when a step in the purchase flow has completed.

+  };
+
   AutocheckoutPageMetaData();
   ~AutocheckoutPageMetaData();
 
@@ -36,6 +46,15 @@ struct AutocheckoutPageMetaData {
   // belong to any autofill flow, it is set to -1.
   int total_pages;
 
+  // A list of elements to click before filling form fields.
+  // Elements have to be clicked in order, and may wait between clicks.
+  std::vector<ClickElement> click_elements_before_formfill;
+
+  // A list of elements to click after filling form fields, and before clicking
+  // page_advance_button.
+  // Elements have to be clicked in order, and may wait between clicks.
+  std::vector<ClickElement> click_elements_after_formfill;
+
   // The proceed element of the multipage Autofill flow. It can be empty
   // if current page is the last page of a flow or isn't a member of a flow.
   WebElementDescriptor proceed_element_descriptor;