Autocheckout: parse multiple clicks setting in autofill response.

components/autofill/browser/autofill_xml_parser.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_BROWSER_AUTOFILL_XML_PARSER_H_
 #define COMPONENTS_AUTOFILL_BROWSER_AUTOFILL_XML_PARSER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 71 matching lines @@
 
  private:
   // A callback for the beginning of a new <element>, called by Expat.
   // |context| is a parsing context used to resolve element/attribute names.
   // |name| is the name of the element.
   // |attrs| is the list of attributes (names and values) for the element.
   virtual void StartElement(buzz::XmlParseContext* context,
                             const char* name,
                             const char** attrs) OVERRIDE;
 
+  // A helper function to parse a <click_elements_before_formfill> or
+  // <click_elements_after_formfill>. A new |WebElementDescriptor| object will
+  // be appended to |click_elements|.
+  void ParseClickElement(std::vector<WebElementDescriptor>* click_elements);
+
+  // A helper function to parse a |WebElementDescriptor|.
+  // |context| is the current parsing context.
+  // |attrs| is the list of attributes (names and values) for the element.
+  // |element_descriptor| will be populated by this function.
+  WebElementDescriptor* ParseElementDescriptor(
+      buzz::XmlParseContext* context,
+      const char** attrs,

[Ilya Sherman, 2013/05/23 09:04:42]

Please document that |attrs| will be modified by calling this method.

[benquan, 2013/05/24 00:45:11]

Nope, the function only changes |attrs| itself (++attrs), and it will not be
carried out of the function.

However, the function could do this to change the the content it points to:
 *attrs = "foo"; 

To prevent that, we should define it as  "const char* const* attrs" not just
"const char** attrs".  buzz::XmlParseHandler should do this as well. 

Const correctness is important but it is tricky to get it right, and easily get
confused by these:

char** a;
const char** a;
char* const* a;
char** const a;
const char* const* a;
const chat* const* const a;
... ...

+      WebElementDescriptor* element_descriptor);
+
   // A helper function to retrieve integer values from strings.  Raises an
   // XML parse error if it fails.
   // |context| is the current parsing context.
   // |value| is the string to convert.
   int GetIntValue(buzz::XmlParseContext* context, const char* attribute);
 
   // The parsed <field type, default value> pairs.
   std::vector<AutofillServerFieldInfo>* field_infos_;
 
   // A flag indicating whether the client should upload Autofill data when this
   // form is submitted.
   UploadRequired* upload_required_;
 
   // The server experiment to which this query response belongs.
   // For the default server implementation, this is empty.
   std::string* experiment_id_;
 
   // Page metadata for multipage autofill flow.
   AutocheckoutPageMetaData* page_meta_data_;
 
+  // The click element the parser is currently processing.
+  WebElementDescriptor* current_click_element_;
+
   DISALLOW_COPY_AND_ASSIGN(AutofillQueryXmlParser);
 };
 
 // The XML parser for handling Autofill upload responses.  Typical upload
 // responses look like:
 //
 // <autofilluploadresponse negativeuploadrate="0.00125" positiveuploadrate="1"/>
 //
 // The positive upload rate is the percentage of uploads to send to the server
 // when something in the users profile matches what they have entered in a form.
@@ skipping 26 matching lines @@
 
   double* positive_upload_rate_;
   double* negative_upload_rate_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillUploadXmlParser);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_BROWSER_AUTOFILL_XML_PARSER_H_