Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: src/core/SkString.cpp

Issue 1548683002: Revert of Add config options to run different GPU APIs to dm and nanobench (Closed) Base URL: https://skia.googlesource.com/skia.git@commandbuffer-as-api-03-context-factory-glcontext-type
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/gpu/gl/command_buffer/SkCommandBufferGLContext.h ('k') | src/gpu/GrContextFactory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkString.cpp
diff --git a/src/core/SkString.cpp b/src/core/SkString.cpp
index b5655e0503be9574f93047dc54f9158b343c25fc..d93f662da3d8bc0a80ca96903752bbcc3977ba1e 100644
--- a/src/core/SkString.cpp
+++ b/src/core/SkString.cpp
@@ -624,35 +624,16 @@
return formattedOutput;
}
-void SkStrSplit(const char* str, const char* delimiters, SkStrSplitMode splitMode,
- SkTArray<SkString>* out) {
- if (splitMode == kCoalesce_SkStrSplitMode) {
+void SkStrSplit(const char* str, const char* delimiters, SkTArray<SkString>* out) {
+ const char* end = str + strlen(str);
+ while (str != end) {
+ // Find a token.
+ const size_t len = strcspn(str, delimiters);
+ out->push_back().set(str, len);
+ str += len;
// Skip any delimiters.
str += strspn(str, delimiters);
}
- if (!*str) {
- return;
- }
-
- while (true) {
- // Find a token.
- const size_t len = strcspn(str, delimiters);
- if (splitMode == kStrict_SkStrSplitMode || len > 0) {
- out->push_back().set(str, len);
- str += len;
- }
-
- if (!*str) {
- return;
- }
- if (splitMode == kCoalesce_SkStrSplitMode) {
- // Skip any delimiters.
- str += strspn(str, delimiters);
- } else {
- // Skip one delimiter.
- str += 1;
- }
- }
}
#undef VSNPRINTF
« no previous file with comments | « include/gpu/gl/command_buffer/SkCommandBufferGLContext.h ('k') | src/gpu/GrContextFactory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698