Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 1548673002: Switch to standard integer types in google_apis/. (Closed)

Created:
5 years ago by Avi (use Gerrit)
Modified:
5 years ago
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to standard integer types in google_apis/. BUG=138542 TBR=rogerta@chromium.org NOPRESUBMIT=true Committed: https://crrev.com/b32eea9bd3e6f79bd3ba15ca0299ccc579d68417 Cr-Commit-Position: refs/heads/master@{#366670}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+520 lines, -400 lines) Patch
M google_apis/drive/auth_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/drive/auth_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/drive/base_requests.h View 16 chunks +30 lines, -27 lines 0 comments Download
M google_apis/drive/base_requests.cc View 13 chunks +27 lines, -26 lines 0 comments Download
M google_apis/drive/base_requests_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M google_apis/drive/drive_api_parser.h View 12 chunks +21 lines, -22 lines 0 comments Download
M google_apis/drive/drive_api_parser.cc View 6 chunks +18 lines, -20 lines 0 comments Download
M google_apis/drive/drive_api_requests.h View 14 chunks +23 lines, -20 lines 0 comments Download
M google_apis/drive/drive_api_requests.cc View 14 chunks +26 lines, -34 lines 0 comments Download
M google_apis/drive/drive_api_requests_unittest.cc View 6 chunks +17 lines, -11 lines 0 comments Download
M google_apis/drive/drive_api_url_generator.h View 2 chunks +4 lines, -1 line 0 comments Download
M google_apis/drive/drive_api_url_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/drive_api_url_generator_unittest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M google_apis/drive/files_list_request_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/request_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/test_util.h View 3 chunks +10 lines, -6 lines 0 comments Download
M google_apis/drive/test_util.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M google_apis/gaia/fake_gaia.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/fake_oauth2_token_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/fake_oauth2_token_service_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/gaia_auth_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/gaia_urls.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/mock_url_fetcher_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher_immediate_error.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/oauth2_api_call_flow.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/oauth2_api_call_flow.cc View 1 chunk +0 lines, -1 line 0 comments Download
M google_apis/gaia/oauth2_mint_token_flow.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/oauth2_mint_token_flow.cc View 1 chunk +2 lines, -1 line 0 comments Download
M google_apis/gaia/oauth2_token_service.h View 1 chunk +3 lines, -1 line 0 comments Download
M google_apis/gaia/oauth2_token_service.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_request.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_request.cc View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M google_apis/gaia/oauth_request_signer.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/oauth_request_signer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M google_apis/gaia/ubertoken_fetcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/base/mcs_message.h View 5 chunks +9 lines, -7 lines 0 comments Download
M google_apis/gcm/base/mcs_message.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M google_apis/gcm/base/mcs_message_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M google_apis/gcm/base/mcs_util.h View 4 chunks +9 lines, -8 lines 0 comments Download
M google_apis/gcm/base/mcs_util.cc View 6 chunks +11 lines, -7 lines 0 comments Download
M google_apis/gcm/base/mcs_util_unittest.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M google_apis/gcm/base/socket_stream.h View 3 chunks +5 lines, -3 lines 0 comments Download
M google_apis/gcm/base/socket_stream.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M google_apis/gcm/base/socket_stream_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M google_apis/gcm/engine/account_mapping.h View 1 chunk +0 lines, -1 line 0 comments Download
M google_apis/gcm/engine/account_mapping.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M google_apis/gcm/engine/checkin_request.h View 2 chunks +7 lines, -5 lines 0 comments Download
M google_apis/gcm/engine/checkin_request.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M google_apis/gcm/engine/checkin_request_unittest.cc View 6 chunks +15 lines, -12 lines 0 comments Download
M google_apis/gcm/engine/connection_factory_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M google_apis/gcm/engine/connection_handler_impl.h View 3 chunks +7 lines, -4 lines 0 comments Download
M google_apis/gcm/engine/connection_handler_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M google_apis/gcm/engine/connection_handler_impl_unittest.cc View 1 3 chunks +6 lines, -4 lines 0 comments Download
M google_apis/gcm/engine/fake_connection_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/engine/fake_connection_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/engine/gcm_registration_request_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/engine/gcm_request_test_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/engine/gcm_store.h View 3 chunks +6 lines, -5 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.h View 2 chunks +5 lines, -3 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.cc View 12 chunks +16 lines, -16 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M google_apis/gcm/engine/gcm_unregistration_request_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/engine/gcm_unregistration_request_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/engine/gservices_settings.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/engine/gservices_settings.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M google_apis/gcm/engine/gservices_settings_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/heartbeat_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/engine/heartbeat_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/engine/instance_id_delete_token_request_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/engine/instance_id_delete_token_request_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/engine/instance_id_get_token_request_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/engine/mcs_client.h View 5 chunks +11 lines, -9 lines 0 comments Download
M google_apis/gcm/engine/mcs_client.cc View 8 chunks +13 lines, -12 lines 0 comments Download
M google_apis/gcm/engine/mcs_client_unittest.cc View 8 chunks +14 lines, -11 lines 0 comments Download
M google_apis/gcm/engine/registration_request.h View 2 chunks +7 lines, -5 lines 0 comments Download
M google_apis/gcm/engine/registration_request.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M google_apis/gcm/engine/registration_request_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/unregistration_request.h View 2 chunks +7 lines, -5 lines 0 comments Download
M google_apis/gcm/engine/unregistration_request.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M google_apis/gcm/engine/unregistration_request_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M google_apis/gcm/monitoring/fake_gcm_stats_recorder.h View 4 chunks +11 lines, -9 lines 0 comments Download
M google_apis/gcm/monitoring/fake_gcm_stats_recorder.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M google_apis/gcm/monitoring/gcm_stats_recorder.h View 5 chunks +10 lines, -9 lines 0 comments Download
M google_apis/gcm/tools/mcs_probe.cc View 6 chunks +9 lines, -6 lines 0 comments Download
M google_apis/google_api_keys.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M google_apis/google_api_keys_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548673002/1
5 years ago (2015-12-22 18:13:23 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/125374)
5 years ago (2015-12-22 18:46:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548673002/20001
5 years ago (2015-12-22 21:21:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-22 22:35:08 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-22 22:36:10 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b32eea9bd3e6f79bd3ba15ca0299ccc579d68417
Cr-Commit-Position: refs/heads/master@{#366670}

Powered by Google App Engine
This is Rietveld 408576698