Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 1548643002: revised strokerect gm (Closed)

Created:
5 years ago by caryclark
Modified:
5 years ago
Reviewers:
hal.canary, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

revised strokerect gm In service of the bug below, revise the gm to show what zero widths draw, and what they should draw (by including rects with fractionally tiny widths). TBR=halcanary@google.com,reed@google.com BUG=1294 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1548643002 Committed: https://skia.googlesource.com/skia/+/c53b82ec0ec496bed8060f73d605347ee65f2543

Patch Set 1 #

Patch Set 2 : handle halfway case in scan converter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -2 lines) Patch
M gm/composeshader.cpp View 1 2 chunks +9 lines, -1 line 0 comments Download
M gm/pathfill.cpp View 1 1 chunk +36 lines, -0 lines 0 comments Download
M gm/strokerect.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M include/core/SkRect.h View 1 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkScalar.h View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548643002/1
5 years ago (2015-12-22 15:34:19 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-22 15:50:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c53b82ec0ec496bed8060f73d605347ee65f2543

Powered by Google App Engine
This is Rietveld 408576698