Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 154863003: cros: Allow timezone change for non guest users. (Closed)

Created:
6 years, 10 months ago by xiyuan
Modified:
6 years, 10 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

cros: Allow timezone change for non guest users. None guest users include authenticated users (regular user, owner), kiosk users and login screen where there is no user. BUG=340843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/chromeos/settings/system_settings_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/login/login_state.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
xiyuan
r228017 change that only authenticated user could change the timezone. I wonder if it is ...
6 years, 10 months ago (2014-02-04 23:53:33 UTC) #1
stevenjb
lgtm
6 years, 10 months ago (2014-02-04 23:59:26 UTC) #2
xiyuan
Thanks for the quick review. :)
6 years, 10 months ago (2014-02-05 00:11:41 UTC) #3
xiyuan
The CQ bit was checked by xiyuan@chromium.org
6 years, 10 months ago (2014-02-05 01:19:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/154863003/1
6 years, 10 months ago (2014-02-05 03:53:26 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 07:25:45 UTC) #6
Message was sent while issue was closed.
Change committed as 248901

Powered by Google App Engine
This is Rietveld 408576698