Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 1548623002: [runtime] Also migrate the Function and GeneratorFunction constructors to C++. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Also migrate the Function and GeneratorFunction constructors to C++. These constructors always go through C++ at least twice anyway, so there's not really a point in trying to implement them in JavaScript. R=yangguo@chromium.org BUG=chromium:535408 LOG=n Committed: https://crrev.com/d1d4fa20b0f04cd3b1510d9004719601c71bf937 Cr-Commit-Position: refs/heads/master@{#33012}

Patch Set 1 #

Patch Set 2 : Fix assertion scope. #

Patch Set 3 : Fix message tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -245 lines) Patch
M src/bootstrapper.cc View 2 chunks +11 lines, -7 lines 0 comments Download
M src/builtins.h View 1 chunk +50 lines, -47 lines 0 comments Download
M src/builtins.cc View 1 4 chunks +136 lines, -1 line 0 comments Download
M src/js/generator.js View 3 chunks +0 lines, -16 lines 0 comments Download
M src/js/v8natives.js View 4 chunks +0 lines, -41 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M test/message/paren_in_arg_string.out View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D test/message/single-function-literal.js View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
D test/message/single-function-literal.out View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D test/mjsunit/regress/regress-function-constructor-receiver.js View 1 chunk +0 lines, -17 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (8 generated)
Benedikt Meurer
5 years ago (2015-12-22 12:34:21 UTC) #1
Benedikt Meurer
Hey Yang, Next yak shaving step. Almost simplified it to a managable level. :-) Please ...
5 years ago (2015-12-22 12:35:25 UTC) #2
Yang
lgtm
5 years ago (2015-12-22 12:38:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548623002/1
5 years ago (2015-12-22 12:39:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/13498)
5 years ago (2015-12-22 12:50:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548623002/20001
5 years ago (2015-12-22 12:59:10 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/871) v8_win_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
5 years ago (2015-12-22 13:16:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548623002/40001
5 years ago (2015-12-22 13:40:43 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-22 14:15:23 UTC) #16
commit-bot: I haz the power
5 years ago (2015-12-22 14:15:57 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d1d4fa20b0f04cd3b1510d9004719601c71bf937
Cr-Commit-Position: refs/heads/master@{#33012}

Powered by Google App Engine
This is Rietveld 408576698