Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1548583002: Replace an assertion with returning false (Closed)

Created:
5 years ago by jun_fang
Modified:
5 years ago
Reviewers:
Lei Zhang, Tom Sepez
CC:
pdfium-reviews_googlegroups.com, kai_jing
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Shorten the description in README.pdfium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
A third_party/libopenjpeg20/0008-jp2_check_color.patch View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/libopenjpeg20/README.pdfium View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libopenjpeg20/jp2.c View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jun_fang
Hi Lei, Please review this CL. Thanks!
5 years ago (2015-12-22 04:22:18 UTC) #2
Lei Zhang
lgtm Feel free to land with the tree closed until we figure out https://bugs.chromium.org/p/pdfium/issues/detail?id=335 - ...
5 years ago (2015-12-23 02:05:57 UTC) #3
Lei Zhang
On 2015/12/23 02:05:57, Lei Zhang wrote: > lgtm > > Feel free to land with ...
5 years ago (2015-12-24 04:06:29 UTC) #4
jun_fang
5 years ago (2015-12-24 06:37:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f1d406f30ccdc5fe705faa590fbac0a8306b161c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698