third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp - Issue 1548523002: Use Document, rather than document element, for implicit root.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

Issue 1548523002: Use Document, rather than document element, for implicit root. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@intersection-observer

Patch Set: Nits, comments, rebaseline Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/IntersectionObserverController.h ('k') | third_party/WebKit/Source/core/dom/NodeIntersectionObserverData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp b/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

index 125c67f46875669c15fe22ff3f0af6a6ec3734f1..2f05ec58127ea23cc0938d49fb2aaa168e042de1 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

+++ b/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

@@ -73,7 +73,7 @@ void IntersectionObserverController::addTrackedObserver(IntersectionObserver& ob

m_trackedIntersectionObservers.add(&observer);

}

-void IntersectionObserverController::removeTrackedObserversForRoot(const Element& root)

+void IntersectionObserverController::removeTrackedObserversForRoot(const Node& root)

{

HeapVector<Member<IntersectionObserver>> toRemove;

for (auto& observer : m_trackedIntersectionObservers) {