net: extract GetDirectoryListingXXX functions into directory_listing.*

net/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chromecast_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//build_overrides/v8.gni")
@@ skipping 417 matching lines @@
     }
 
     # ICU support.
     deps += [
       "//base:i18n",
       "//third_party/icu",
     ]
     sources += [
       "base/filename_util_icu.cc",
       "base/net_string_util_icu.cc",
-      "base/net_util_icu.cc",

[tfarina, 2015/12/21 20:47:47]

looks like I will have problem with this. So, will I have to have a
directory_listing_icu.cc?

[eroman, 2015/12/21 21:17:35]

My expectation is that GetDirectoryListingHeader() will just be needed from the
same configurations as GetDirectoryListingEntry(), so grouping them in the same
file and conditionally building _should_ be fine.

@mmenke: Do you want the renamed file to be called directory_listing_icu.cc
rather than directory_listing.cc ?

[tfarina, 2015/12/21 22:20:28]

I got back with directory_listing.cc. I'm unsure how best to build it
conditionally though.

     ]
   }
 }
 
 if (is_android) {
   # Same as net, but with ICU, file, ftp, and websocket support stripped.
   component("net_small") {
     sources = net_shared_sources
 
     # Add back some sources that were otherwise filtered out.
@@ skipping 1244 matching lines @@
   if (enable_websockets) {
     sources += [ "websockets/websocket_frame_perftest.cc" ]
   }
 
   if (use_v8_in_net) {
     deps += [ ":net_with_v8" ]
   } else {
     sources -= [ "proxy/proxy_resolver_perftest.cc" ]
   }
 }