Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1548483003: X87: [runtime] Rewrite Function.prototype.toString in C++. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
4 years, 12 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Rewrite Function.prototype.toString in C++. port 4acca53e62cdfe6f3c495c87ca7d3c8fe1059f01(r32996) original commit message: There's actually no point trying to do Function.prototype.toString in JavaScript, as it always calls into C++ at least once, so it only complicates things (esp. once we start optimizing bound functions). Drive-by-fix: Rename FunctionApply and FunctionCall builtins to also reflect the fact that these are builtins in the Function.prototype and not on Function itself. BUG= Committed: https://crrev.com/a1c2e40276ea7f27408d563b91ffcfdb1ca81a6f Cr-Commit-Position: refs/heads/master@{#33017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -47 lines) Patch
M src/x87/builtins-x87.cc View 2 chunks +48 lines, -47 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-22 08:44:35 UTC) #2
Weiliang
lgtm
4 years, 12 months ago (2015-12-23 04:48:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548483003/1
4 years, 12 months ago (2015-12-23 04:48:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-23 05:05:38 UTC) #6
commit-bot: I haz the power
4 years, 12 months ago (2015-12-23 05:05:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1c2e40276ea7f27408d563b91ffcfdb1ca81a6f
Cr-Commit-Position: refs/heads/master@{#33017}

Powered by Google App Engine
This is Rietveld 408576698