mojo/converters/surfaces/surfaces_type_converters.cc - Issue 1548443002: Introducing gpu::CommandBufferId as a distinct, IdType<...>-based type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/converters/surfaces/surfaces_type_converters.cc

Issue 1548443002: Introducing gpu::CommandBufferId as a distinct, IdType<...>-based type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@type-safe-save-package-id-self-contained

Patch Set: Moved base/id_type... into gpu/command_buffer/common/id_type.… Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/common/id_type.h ('K') | « media/video/gpu_memory_buffer_video_frame_pool_unittest.cc ('k') | mojo/converters/surfaces/tests/surface_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/converters/surfaces/surfaces_type_converters.cc

diff --git a/mojo/converters/surfaces/surfaces_type_converters.cc b/mojo/converters/surfaces/surfaces_type_converters.cc

index bff1f7016b00ee31650e74a1f6018c1f4186e882..8c624779182e43c40ca130d73d3c6a552f9eb03a 100644

--- a/mojo/converters/surfaces/surfaces_type_converters.cc

+++ b/mojo/converters/surfaces/surfaces_type_converters.cc

@@ -543,7 +543,7 @@ SyncTokenPtr TypeConverter<SyncTokenPtr, gpu::SyncToken>::Convert(

sync_token->namespace_id =

static_cast<CommandBufferNamespace>(input.namespace_id());

sync_token->extra_data_field = input.extra_data_field();

- sync_token->command_buffer_id = input.command_buffer_id();

+ sync_token->command_buffer_id = input.command_buffer_id().GetUnsafeValue();

sync_token->release_count = input.release_count();

return sync_token;

}

@@ -553,8 +553,10 @@ gpu::SyncToken TypeConverter<gpu::SyncToken, SyncTokenPtr>::Convert(

const SyncTokenPtr& input) {

const gpu::CommandBufferNamespace namespace_id =

static_cast<gpu::CommandBufferNamespace>(input->namespace_id);

- gpu::SyncToken sync_token(namespace_id, input->extra_data_field,

- input->command_buffer_id, input->release_count);

+ gpu::SyncToken sync_token(

+ namespace_id, input->extra_data_field,

+ gpu::CommandBufferId::FromUnsafeValue(input->command_buffer_id),

+ input->release_count);

if (input->verified_flush)

sync_token.SetVerifyFlush();