gpu/command_buffer/client/gles2_implementation.cc - Issue 1548443002: Introducing gpu::CommandBufferId as a distinct, IdType<...>-based type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/client/gles2_implementation.cc

Issue 1548443002: Introducing gpu::CommandBufferId as a distinct, IdType<...>-based type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@type-safe-save-package-id-self-contained

Patch Set: Moved base/id_type... into gpu/command_buffer/common/id_type.… Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/save_types.h ('K') | « gpu/command_buffer/client/client_test_helper.h ('k') | gpu/command_buffer/client/gles2_implementation_unittest.cc » ('j') | gpu/command_buffer/common/id_type.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/client/gles2_implementation.cc

diff --git a/gpu/command_buffer/client/gles2_implementation.cc b/gpu/command_buffer/client/gles2_implementation.cc

index a53b9b0e9e8cd88f05d59e620532b78a0ce5c1e4..266698ac1a0b29c634137c7502e8bc31e50235ec 100644

--- a/gpu/command_buffer/client/gles2_implementation.cc

+++ b/gpu/command_buffer/client/gles2_implementation.cc

@@ -147,8 +147,9 @@ GLES2Implementation::GLES2Implementation(

share_group_ =

(share_group ? share_group

- : new ShareGroup(bind_generates_resource,

- gpu_control_->GetCommandBufferID()));

+ : new ShareGroup(

+ bind_generates_resource,

+ gpu_control_->GetCommandBufferID().GetUnsafeValue()));

DCHECK(share_group_->bind_generates_resource() == bind_generates_resource);

memset(&reserved_ids_, 0, sizeof(reserved_ids_));

@@ -5656,7 +5657,8 @@ void GLES2Implementation::WaitSyncTokenCHROMIUM(const GLbyte* sync_token) {

helper_->WaitSyncTokenCHROMIUM(

static_cast<GLint>(sync_token_data.namespace_id()),

- sync_token_data.command_buffer_id(), sync_token_data.release_count());

+ sync_token_data.command_buffer_id().GetUnsafeValue(),

+ sync_token_data.release_count());

}