gpu/command_buffer/service/gles2_cmd_decoder.h - Issue 1548443002: Introducing gpu::CommandBufferId as a distinct, IdType<...>-based type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.h

Issue 1548443002: Introducing gpu::CommandBufferId as a distinct, IdType<...>-based type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@type-safe-save-package-id-self-contained

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/command_buffer/service/gles2_cmd_decoder.h

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.h b/gpu/command_buffer/service/gles2_cmd_decoder.h

index e960c5da0c358a989f2b2ea502b8aa7525b22129..8c3fbf0f8687209ab910d32e04a6276a5c92b27f 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder.h

+++ b/gpu/command_buffer/service/gles2_cmd_decoder.h

@@ -19,6 +19,7 @@

#include "base/time/time.h"

#include "build/build_config.h"

#include "gpu/command_buffer/common/capabilities.h"

+#include "gpu/command_buffer/common/command_buffer_id.h"

#include "gpu/command_buffer/common/constants.h"

#include "gpu/command_buffer/service/common_decoder.h"

#include "gpu/gpu_export.h"

@@ -82,8 +83,9 @@ class GPU_EXPORT GLES2Decoder : public base::SupportsWeakPtr<GLES2Decoder>,

typedef error::Error Error;

typedef base::Callback<void(uint64_t release)> FenceSyncReleaseCallback;

typedef base::Callback<bool(gpu::CommandBufferNamespace namespace_id,

- uint64_t command_buffer_id,

- uint64_t release)> WaitFenceSyncCallback;

+ gpu::CommandBufferId command_buffer_id,

+ uint64_t release)>

+ WaitFenceSyncCallback;

// The default stencil mask, which has all bits set. This really should be a

// GLuint, but we can't #include gl_bindings.h in this file without causing

« no previous file with comments | « gpu/command_buffer/common/sync_token.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | ipc/ipc_message_utils.h » ('J')