ppapi/proxy/ppb_graphics_3d_proxy.h - Issue 1548443002: Introducing gpu::CommandBufferId as a distinct, IdType<...>-based type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/ppb_graphics_3d_proxy.h

Issue 1548443002: Introducing gpu::CommandBufferId as a distinct, IdType<...>-based type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@type-safe-save-package-id-self-contained

Patch Set: Rebasing... Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/proxy/ppb_graphics_3d_proxy.h

diff --git a/ppapi/proxy/ppb_graphics_3d_proxy.h b/ppapi/proxy/ppb_graphics_3d_proxy.h

index f6805da2827a807848528181b851a9a8fceba668..e2b4dda8207f3e9714a0ba917d557afcaeeea57d 100644

--- a/ppapi/proxy/ppb_graphics_3d_proxy.h

+++ b/ppapi/proxy/ppb_graphics_3d_proxy.h

@@ -11,6 +11,7 @@

#include "base/macros.h"

#include "gpu/command_buffer/common/command_buffer.h"

+#include "gpu/command_buffer/common/command_buffer_id.h"

#include "ppapi/c/pp_graphics_3d.h"

#include "ppapi/c/pp_instance.h"

#include "ppapi/proxy/interface_proxy.h"

@@ -41,7 +42,7 @@ class PPAPI_PROXY_EXPORT Graphics3D : public PPB_Graphics3D_Shared {

bool Init(gpu::gles2::GLES2Implementation* share_gles2,

const gpu::Capabilities& capabilities,

const SerializedHandle& shared_state,

- uint64_t command_buffer_id);

+ gpu::CommandBufferId command_buffer_id);

// Graphics3DTrusted API. These are not implemented in the proxy.

PP_Bool SetGetBuffer(int32_t shm_id) override;

@@ -88,7 +89,7 @@ class PPB_Graphics3D_Proxy : public InterfaceProxy {

HostResource* result,

gpu::Capabilities* capabilities,

SerializedHandle* handle,

- uint64_t* command_buffer_id);

+ gpu::CommandBufferId* command_buffer_id);

void OnMsgSetGetBuffer(const HostResource& context, int32_t id);

void OnMsgWaitForTokenInRange(const HostResource& context,

int32_t start,

« no previous file with comments | « ppapi/proxy/ppapi_messages.h ('k') | ppapi/proxy/ppb_graphics_3d_proxy.cc » ('j') | no next file with comments »