Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Unified Diff: gpu/command_buffer/service/sync_point_manager.cc

Issue 1548443002: Introducing gpu::CommandBufferId as a distinct, IdType<...>-based type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@type-safe-save-package-id-self-contained
Patch Set: Rebasing... Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/sync_point_manager.cc
diff --git a/gpu/command_buffer/service/sync_point_manager.cc b/gpu/command_buffer/service/sync_point_manager.cc
index c3d7d6827815a02c493265ce5adc1e2822ad93a3..38d603e41adffeac74492266dd9f89309528068e 100644
--- a/gpu/command_buffer/service/sync_point_manager.cc
+++ b/gpu/command_buffer/service/sync_point_manager.cc
@@ -327,12 +327,12 @@ void SyncPointClient::ReleaseFenceSync(uint64_t release) {
SyncPointClient::SyncPointClient()
: sync_point_manager_(nullptr),
namespace_id_(gpu::CommandBufferNamespace::INVALID),
- client_id_(0) {}
+ client_id_() {}
SyncPointClient::SyncPointClient(SyncPointManager* sync_point_manager,
scoped_refptr<SyncPointOrderData> order_data,
CommandBufferNamespace namespace_id,
- uint64_t client_id)
+ CommandBufferId client_id)
: sync_point_manager_(sync_point_manager),
client_state_(new SyncPointClientState(order_data)),
namespace_id_(namespace_id),
@@ -351,7 +351,7 @@ SyncPointManager::~SyncPointManager() {
scoped_ptr<SyncPointClient> SyncPointManager::CreateSyncPointClient(
scoped_refptr<SyncPointOrderData> order_data,
CommandBufferNamespace namespace_id,
- uint64_t client_id) {
+ CommandBufferId client_id) {
DCHECK_GE(namespace_id, 0);
DCHECK_LT(static_cast<size_t>(namespace_id), arraysize(client_maps_));
base::AutoLock auto_lock(client_maps_lock_);
@@ -370,7 +370,8 @@ scoped_ptr<SyncPointClient> SyncPointManager::CreateSyncPointClientWaiter() {
}
scoped_refptr<SyncPointClientState> SyncPointManager::GetSyncPointClientState(
- CommandBufferNamespace namespace_id, uint64_t client_id) {
+ CommandBufferNamespace namespace_id,
+ CommandBufferId client_id) {
if (namespace_id >= 0) {
DCHECK_LT(static_cast<size_t>(namespace_id), arraysize(client_maps_));
base::AutoLock auto_lock(client_maps_lock_);
@@ -388,7 +389,8 @@ uint32_t SyncPointManager::GenerateOrderNumber() {
}
void SyncPointManager::DestroySyncPointClient(
- CommandBufferNamespace namespace_id, uint64_t client_id) {
+ CommandBufferNamespace namespace_id,
+ CommandBufferId client_id) {
DCHECK_GE(namespace_id, 0);
DCHECK_LT(static_cast<size_t>(namespace_id), arraysize(client_maps_));
« no previous file with comments | « gpu/command_buffer/service/sync_point_manager.h ('k') | gpu/command_buffer/service/sync_point_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698