gpu/command_buffer/client/gpu_control.h - Issue 1548443002: Introducing gpu::CommandBufferId as a distinct, IdType<...>-based type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/client/gpu_control.h

Issue 1548443002: Introducing gpu::CommandBufferId as a distinct, IdType<...>-based type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@type-safe-save-package-id-self-contained

Patch Set: Rebasing... Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/command_buffer/client/gpu_control.h

diff --git a/gpu/command_buffer/client/gpu_control.h b/gpu/command_buffer/client/gpu_control.h

index 28cd67ae6d1c4c092cc128de8bf45d26d19319f4..12ad377b5535cb0cb632e8f766e7900430b16b27 100644

--- a/gpu/command_buffer/client/gpu_control.h

+++ b/gpu/command_buffer/client/gpu_control.h

@@ -13,6 +13,7 @@

#include "base/callback.h"

#include "base/macros.h"

#include "gpu/command_buffer/common/capabilities.h"

+#include "gpu/command_buffer/common/command_buffer_id.h"

#include "gpu/command_buffer/common/constants.h"

#include "gpu/command_buffer/common/mailbox.h"

#include "gpu/gpu_export.h"

@@ -83,7 +84,7 @@ class GPU_EXPORT GpuControl {

// extra field to identify unverified sync tokens for the implementation of

// the CanWaitUnverifiedSyncToken() function.

virtual CommandBufferNamespace GetNamespaceID() const = 0;

- virtual uint64_t GetCommandBufferID() const = 0;

+ virtual CommandBufferId GetCommandBufferID() const = 0;

virtual int32_t GetExtraCommandBufferData() const = 0;

// Fence Syncs use release counters at a context level, these fence syncs

« no previous file with comments | « gpu/command_buffer/client/gles2_implementation_unittest.cc ('k') | gpu/command_buffer/common/BUILD.gn » ('j') | no next file with comments »