Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1548403002: Avoid endless loop when computing line boundaries in contentEditable. (Closed)

Created:
4 years, 12 months ago by dmazzoni
Modified:
4 years, 11 months ago
Reviewers:
je_julie
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, nektarios, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews, dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid endless loop when computing line boundaries in contentEditable. BUG=535323, 572777 Committed: https://crrev.com/251167c9f19db05cff206db05a77d5e76f25b587 Cr-Commit-Position: refs/heads/master@{#367213}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/accessibility/line-for-index-endless-loop.html View 1 chunk +32 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dmazzoni
4 years, 12 months ago (2015-12-28 23:44:33 UTC) #2
je_julie
On 2015/12/28 23:44:33, dmazzoni wrote: LGTM!
4 years, 11 months ago (2015-12-30 02:10:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548403002/1
4 years, 11 months ago (2015-12-30 22:50:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-31 00:38:46 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2015-12-31 00:39:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/251167c9f19db05cff206db05a77d5e76f25b587
Cr-Commit-Position: refs/heads/master@{#367213}

Powered by Google App Engine
This is Rietveld 408576698