Remove dead WebCompositorInputHandler related code

Remove dead WebCompositorInputHandler related code

This code is all a no-op as of r201016

BUG=241641
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201750

[jamesr, 2013-05-22 01:15:25]

https://codereview.chromium.org/15484013/diff/1/content/browser/android/sync_...
File content/browser/android/sync_input_event_filter.cc (right):

https://codereview.chromium.org/15484013/diff/1/content/browser/android/sync_...
content/browser/android/sync_input_event_filter.cc:24: return
INPUT_EVENT_ACK_STATE_NOT_CONSUMED;
this is just a stub, of course - I'm pretty sure the actual implementation of
this will need to call in to the appropriate content::SynchronousCompositor
instance

[Jói, 2013-05-22 02:25:59]

LGTM

https://codereview.chromium.org/15484013/diff/1/content/browser/android/sync_...
File content/browser/android/sync_input_event_filter.cc (right):

https://codereview.chromium.org/15484013/diff/1/content/browser/android/sync_...
content/browser/android/sync_input_event_filter.cc:24: return
INPUT_EVENT_ACK_STATE_NOT_CONSUMED;
On 2013/05/22 01:15:25, jamesr wrote:
> this is just a stub, of course - I'm pretty sure the actual implementation of
> this will need to call in to the appropriate content::SynchronousCompositor
> instance

Do you want to leave a comment to this effect, perhaps?

[joth, 2013-05-22 04:34:24]

https://codereview.chromium.org/15484013/diff/1/content/browser/android/sync_...
File content/browser/android/sync_input_event_filter.cc (right):

https://codereview.chromium.org/15484013/diff/1/content/browser/android/sync_...
content/browser/android/sync_input_event_filter.cc:24: return
INPUT_EVENT_ACK_STATE_NOT_CONSUMED;
On 2013/05/22 01:15:25, jamesr wrote:
> this is just a stub, of course - I'm pretty sure the actual implementation of
> this will need to call in to the appropriate content::SynchronousCompositor
> instance

We'll need to jiggle some bits around to make it work as SynchronousCompositor
is in content/public/renderer and so can't be #included in this file. 
Possibly, turn SyncInputEventFilter into an abstract base class in
content/public/common, and we'd ask SynchronousCompositor to vend an instance of
a subclass of it, which would get passed on into here.
(So for this CL, this .cc file could just be deleted leaving only the abstract
base)

https://codereview.chromium.org/15484013/diff/1/content/public/browser/androi...
File content/public/browser/android/content_view_core.h (left):

https://codereview.chromium.org/15484013/diff/1/content/public/browser/androi...
content/public/browser/android/content_view_core.h:60:
WebKit::WebCompositorInputHandler* input_handler) = 0;
Rather than remove then re-add this function, could this just switch straight to
having SyncInputEventHandler as the param?

[jamesr, 2013-05-22 07:05:09]

https://codereview.chromium.org/15484013/diff/1/content/browser/android/sync_...
File content/browser/android/sync_input_event_filter.cc (right):

https://codereview.chromium.org/15484013/diff/1/content/browser/android/sync_...
content/browser/android/sync_input_event_filter.cc:24: return
INPUT_EVENT_ACK_STATE_NOT_CONSUMED;
On 2013/05/22 04:34:24, joth wrote:
> On 2013/05/22 01:15:25, jamesr wrote:
> > this is just a stub, of course - I'm pretty sure the actual implementation
of
> > this will need to call in to the appropriate content::SynchronousCompositor
> > instance
> 
> We'll need to jiggle some bits around to make it work as SynchronousCompositor
> is in content/public/renderer and so can't be #included in this file. 
> Possibly, turn SyncInputEventFilter into an abstract base class in
> content/public/common, and we'd ask SynchronousCompositor to vend an instance
of
> a subclass of it, which would get passed on into here.
> (So for this CL, this .cc file could just be deleted leaving only the abstract
> base)

I'd rather leave this to the folks working on android_webview - I don't even
have the ability to compile this code.

https://codereview.chromium.org/15484013/diff/1/content/public/browser/androi...
File content/public/browser/android/content_view_core.h (left):

https://codereview.chromium.org/15484013/diff/1/content/public/browser/androi...
content/public/browser/android/content_view_core.h:60:
WebKit::WebCompositorInputHandler* input_handler) = 0;
On 2013/05/22 04:34:24, joth wrote:
> Rather than remove then re-add this function, could this just switch straight
to
> having SyncInputEventHandler as the param?  

No. I don't know what the hookup will look like (and I don't think anyone else
quite does yet) - adding API for it would be premature.

[joth, 2013-05-22 18:10:05]

lgtm


On 22 May 2013 00:05, <jamesr@chromium.org> wrote:

>
> https://codereview.chromium.**org/15484013/diff/1/content/**
>
browser/android/sync_input_**event_filter.cc<https://codereview.chromium.org/15484013/diff/1/content/browser/android/sync_input_event_filter.cc>
> File content/browser/android/sync_**input_event_filter.cc (right):
>
> https://codereview.chromium.**org/15484013/diff/1/content/**
>
browser/android/sync_input_**event_filter.cc#newcode24<https://codereview.chromium.org/15484013/diff/1/content/browser/android/sync_input_event_filter.cc#newcode24>
> content/browser/android/sync_**input_event_filter.cc:24: return
> INPUT_EVENT_ACK_STATE_NOT_**CONSUMED;
> On 2013/05/22 04:34:24, joth wrote:
>
>> On 2013/05/22 01:15:25, jamesr wrote:
>> > this is just a stub, of course - I'm pretty sure the actual
>>
> implementation of
>
>> > this will need to call in to the appropriate
>>
> content::SynchronousCompositor
>
>> > instance
>>
>
>  We'll need to jiggle some bits around to make it work as
>>
> SynchronousCompositor
>
>> is in content/public/renderer and so can't be #included in this file.
>> Possibly, turn SyncInputEventFilter into an abstract base class in
>> content/public/common, and we'd ask SynchronousCompositor to vend an
>>
> instance of
>
>> a subclass of it, which would get passed on into here.
>> (So for this CL, this .cc file could just be deleted leaving only the
>>
> abstract
>
>> base)
>>
>
> I'd rather leave this to the folks working on android_webview - I don't
> even have the ability to compile this code.
>
>
compiling is easy enough, either 'git try android_dbg' or  follow
https://code.google.com/p/chromium/wiki/AndroidBuildInstructions to build
locally.
But yes, I agree on the wider point that depending how Martin's root layer
scroll delegate stuff comes together, my suggestions may not be the right
way (I was mostly making them to try and kick off discussion on how that
stuff should move forward)



> https://codereview.chromium.**org/15484013/diff/1/content/**
>
public/browser/android/**content_view_core.h<https://codereview.chromium.org/15484013/diff/1/content/public/browser/android/content_view_core.h>
> File content/public/browser/**android/content_view_core.h (left):
>
> https://codereview.chromium.**org/15484013/diff/1/content/**
>
public/browser/android/**content_view_core.h#oldcode60<https://codereview.chromium.org/15484013/diff/1/content/public/browser/android/content_view_core.h#oldcode60>
> content/public/browser/**android/content_view_core.h:**60:
> WebKit::**WebCompositorInputHandler* input_handler) = 0;
> On 2013/05/22 04:34:24, joth wrote:
>
>> Rather than remove then re-add this function, could this just switch
>>
> straight to
>
>> having SyncInputEventHandler as the param?
>>
>
> No. I don't know what the hookup will look like (and I don't think
> anyone else quite does yet) - adding API for it would be premature.
>
>
https://codereview.chromium.**org/15484013/<https://codereview.chromium.org/1...
>

[commit-bot: I haz the power, 2013-05-22 18:12:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/15484013/1

[commit-bot: I haz the power, 2013-05-22 18:20:43]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[jschuh, 2013-05-22 19:14:19]

message removal. rubberstamp ipc security lgtm.

[commit-bot: I haz the power, 2013-05-22 19:15:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/15484013/1

[commit-bot: I haz the power, 2013-05-23 11:15:40]

Change committed as 201750