Font::drawGlyphs() cleanup

Font::drawGlyphs() cleanup

Font::drawGlyphs() is a fallback/legacy code path, only used in
drawGlyphBuffer() when we fail to build text blobs due to
verticalAnyUpright text.  Hence, the existing horizontal optimization is
no longer reachable.

Remove the dead code and associated helper method.

Also

  * fold the remaining paintGlyphs helper into drawGlyphs
  * drop unused textBounds param
  * use a scoped SkAutoCanvasRestore instead of explicit restore

No functional changes.

R=eae@chromium.org,drott@chromium.org,jbroman@chromium.org

Committed: https://crrev.com/942b31f521d3d7683f3864f08cc60410184d2329
Cr-Commit-Position: refs/heads/master@{#367011}

[f(malita), 2015-12-28 18:09:17]

Description was changed from

==========
Font::drawGlyphs() cleanup

Font::drawGlyphs() is a fallback/legacy code path, only used in
drawGlyphBuffer() when we fail to build text blobs due to
verticalAnyUpright text.  Hence, the existing horizontal optimization is
no longer reachable.

Remove the dead code and associated helper method.

Also

  * fold the remaining paintGlyphs helper into drawGlyphs
  * drop unused textBounds param
  * use a scoped SkAutoCanvasRestore instead of explicit restore

No functional changes.

R=eae@chromium.org,drott@chromium.org,jbroman@chromium.org
==========

to

==========
Font::drawGlyphs() cleanup

Font::drawGlyphs() is a fallback/legacy code path, only used in
drawGlyphBuffer() when we fail to build text blobs due to
verticalAnyUpright text.  Hence, the existing horizontal optimization is
no longer reachable.

Remove the dead code and associated helper method.

Also

  * fold the remaining paintGlyphs helper into drawGlyphs
  * drop unused textBounds param
  * use a scoped SkAutoCanvasRestore instead of explicit restore

No functional changes.

R=eae@chromium.org,drott@chromium.org,jbroman@chromium.org
==========

[f(malita), 2015-12-28 18:09:17]

fmalita@chromium.org changed reviewers:
- drott@chromium.org, eae@chromium.org, jbroman@chromium.org

[f(malita), 2015-12-28 18:28:02]

fmalita@chromium.org changed reviewers:
+ drott@chromium.org, eae@chromium.org, jbroman@chromium.org

[eae, 2015-12-28 19:40:52]

LGTM
Very nice, thanks for taking the time to do this!

[f(malita), 2015-12-28 20:34:53]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2015-12-28 20:35:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1548333002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1548333002/20001

[commit-bot: I haz the power, 2015-12-28 20:39:14]

Description was changed from

==========
Font::drawGlyphs() cleanup

Font::drawGlyphs() is a fallback/legacy code path, only used in
drawGlyphBuffer() when we fail to build text blobs due to
verticalAnyUpright text.  Hence, the existing horizontal optimization is
no longer reachable.

Remove the dead code and associated helper method.

Also

  * fold the remaining paintGlyphs helper into drawGlyphs
  * drop unused textBounds param
  * use a scoped SkAutoCanvasRestore instead of explicit restore

No functional changes.

R=eae@chromium.org,drott@chromium.org,jbroman@chromium.org
==========

to

==========
Font::drawGlyphs() cleanup

Font::drawGlyphs() is a fallback/legacy code path, only used in
drawGlyphBuffer() when we fail to build text blobs due to
verticalAnyUpright text.  Hence, the existing horizontal optimization is
no longer reachable.

Remove the dead code and associated helper method.

Also

  * fold the remaining paintGlyphs helper into drawGlyphs
  * drop unused textBounds param
  * use a scoped SkAutoCanvasRestore instead of explicit restore

No functional changes.

R=eae@chromium.org,drott@chromium.org,jbroman@chromium.org
==========

[commit-bot: I haz the power, 2015-12-28 20:39:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-28 20:40:31]

Description was changed from

==========
Font::drawGlyphs() cleanup

Font::drawGlyphs() is a fallback/legacy code path, only used in
drawGlyphBuffer() when we fail to build text blobs due to
verticalAnyUpright text.  Hence, the existing horizontal optimization is
no longer reachable.

Remove the dead code and associated helper method.

Also

  * fold the remaining paintGlyphs helper into drawGlyphs
  * drop unused textBounds param
  * use a scoped SkAutoCanvasRestore instead of explicit restore

No functional changes.

R=eae@chromium.org,drott@chromium.org,jbroman@chromium.org
==========

to

==========
Font::drawGlyphs() cleanup

Font::drawGlyphs() is a fallback/legacy code path, only used in
drawGlyphBuffer() when we fail to build text blobs due to
verticalAnyUpright text.  Hence, the existing horizontal optimization is
no longer reachable.

Remove the dead code and associated helper method.

Also

  * fold the remaining paintGlyphs helper into drawGlyphs
  * drop unused textBounds param
  * use a scoped SkAutoCanvasRestore instead of explicit restore

No functional changes.

R=eae@chromium.org,drott@chromium.org,jbroman@chromium.org

Committed: https://crrev.com/942b31f521d3d7683f3864f08cc60410184d2329
Cr-Commit-Position: refs/heads/master@{#367011}
==========

[commit-bot: I haz the power, 2015-12-28 20:40:32]

Patchset 2 (id:??) landed as
https://crrev.com/942b31f521d3d7683f3864f08cc60410184d2329
Cr-Commit-Position: refs/heads/master@{#367011}