Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1548323002: Add -Wno-deprecated-declarations on iOS in preparation of changing SDK. (Closed)

Created:
4 years, 12 months ago by sdefresne
Modified:
4 years, 12 months ago
Reviewers:
jif
CC:
cbentzel+watch_chromium.org, chromium-reviews, sdefresne+watch_chromium.org, pkl (ping after 24h if needed)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add -Wno-deprecated-declarations on iOS in preparation of changing SDK. iOS 8 and 9 deprecated many APIs. Add -Wno-deprecated-declarations to iOS targets until the corresponding deprecated API usages are removed. BUG=569158, 571217 Committed: https://crrev.com/292dee05c01afc6d6ae1c3945ef74bdb23e62cde Cr-Commit-Position: refs/heads/master@{#366990}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M ios/chrome/ios_chrome.gyp View 1 chunk +8 lines, -0 lines 0 comments Download
M ios/crnet/test/crnet_test.gyp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
sdefresne
Please take a look and send to CQ. pkl: FYI
4 years, 12 months ago (2015-12-28 17:58:35 UTC) #3
jif
lgtm
4 years, 12 months ago (2015-12-28 18:20:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548323002/1
4 years, 12 months ago (2015-12-28 18:20:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 18:25:39 UTC) #7
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 18:26:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/292dee05c01afc6d6ae1c3945ef74bdb23e62cde
Cr-Commit-Position: refs/heads/master@{#366990}

Powered by Google App Engine
This is Rietveld 408576698